-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubevirt: Network binding plugin #2603
Conversation
Skipping CI for Draft Pull Request. |
1 similar comment
Skipping CI for Draft Pull Request. |
f9b95d5
to
7944d59
Compare
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
okd-hco-e2e-operator-sdk-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-aws, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-operator-sdk-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc |
hco-e2e-kv-smoke-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Alona Paz <[email protected]>
7944d59
to
4578536
Compare
hco-e2e-kv-smoke-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-kv-smoke-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@AlonaKaplan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
hco-e2e-upgrade-prev-operator-sdk-aws lane passed |
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters + adding the appropriate NAD). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters + adding the appropriate NAD). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] kubevirt#2603 Signed-off-by: Ram Lavi <[email protected]>
* api: Introduce PrimaryUserDefinedNetworkBinding FG enabler Introduce a new enabler: PrimaryUserDefinedNetworkBinding. The default value is false. This commit only adds the relevant API and documentation. The logic of this enabler will be added in later commits. Signed-off-by: Ram Lavi <[email protected]> * hco-operator: Add primary UDN Binding image env var Adding a new image that is currently created by kubevirt/kubevirt [0]. [0] kubevirt/kubevirt#10425 Signed-off-by: Ram Lavi <[email protected]> * util/cluster: Set HCO main() to fail if PrimaryUDNImageEnvV env var is not set Signed-off-by: Ram Lavi <[email protected]> * operands/kubevirt: Set Kubevirt CR new primary UDN Binding plugin The ability to register network bindings to Kubevirt VMs was proposed [0] in order to allow Kubevirt VMs to connect to network bindings and gain advanced user defined network capabilities. The configuration is added to the kubevirt CR (kubevirt feature gate* + configuring the binding parameters). This commit deploys and registers a primary user-defined-network (UDN) binding to the kubevirt CR, so it could be used by kubevirt users. * enabling the `NetworkBindingPlugins` kubevirt feature-gate on kubevirt CR is not needed as it is already set by default by HCO [1]. [0] kubevirt/community#280 [1] #2603 Signed-off-by: Ram Lavi <[email protected]> * docs/cluster-configuration: Add primaryUserDefinedNetworkBinding FG Signed-off-by: Ram Lavi <[email protected]> --------- Signed-off-by: Ram Lavi <[email protected]>
What this PR does / why we need it:
Enable NetworkBindingPlugins feature gate by default and propogate the HCO network bindig plugin map to the kubevirt CR.
Reviewer Checklist
Jira Ticket:
Release note: