Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate vddkInitImage in order to remove it on the next version #2798

Merged
merged 1 commit into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/v1beta1/hyperconverged_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ type HyperConvergedSpec struct {
ScratchSpaceStorageClass *string `json:"scratchSpaceStorageClass,omitempty"`

// VDDK Init Image eventually used to import VMs from external providers
//
// Deprecated: please use the Migration Toolkit for Virtualization
// +optional
VddkInitImage *string `json:"vddkInitImage,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion api/v1beta1/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions config/crd/bases/hco.kubevirt.io_hyperconvergeds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2822,8 +2822,11 @@ spec:
- BlockUninstallIfWorkloadsExist
type: string
vddkInitImage:
description: VDDK Init Image eventually used to import VMs from external
providers
description: |-
VDDK Init Image eventually used to import VMs from external providers


Deprecated: please use the Migration Toolkit for Virtualization
type: string
virtualMachineOptions:
default:
Expand Down
7 changes: 5 additions & 2 deletions deploy/crds/hco00.crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2822,8 +2822,11 @@ spec:
- BlockUninstallIfWorkloadsExist
type: string
vddkInitImage:
description: VDDK Init Image eventually used to import VMs from external
providers
description: |-
VDDK Init Image eventually used to import VMs from external providers


Deprecated: please use the Migration Toolkit for Virtualization
type: string
virtualMachineOptions:
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2822,8 +2822,11 @@ spec:
- BlockUninstallIfWorkloadsExist
type: string
vddkInitImage:
description: VDDK Init Image eventually used to import VMs from external
providers
description: |-
VDDK Init Image eventually used to import VMs from external providers


Deprecated: please use the Migration Toolkit for Virtualization
type: string
virtualMachineOptions:
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2822,8 +2822,11 @@ spec:
- BlockUninstallIfWorkloadsExist
type: string
vddkInitImage:
description: VDDK Init Image eventually used to import VMs from external
providers
description: |-
VDDK Init Image eventually used to import VMs from external providers


Deprecated: please use the Migration Toolkit for Virtualization
type: string
virtualMachineOptions:
default:
Expand Down
2 changes: 1 addition & 1 deletion docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ HyperConvergedSpec defines the desired state of HyperConverged
| certConfig | certConfig holds the rotation policy for internal, self-signed certificates | [HyperConvergedCertConfig](#hyperconvergedcertconfig) | {"ca": {"duration": "48h0m0s", "renewBefore": "24h0m0s"}, "server": {"duration": "24h0m0s", "renewBefore": "12h0m0s"}} | false |
| resourceRequirements | ResourceRequirements describes the resource requirements for the operand workloads. | *[OperandResourceRequirements](#operandresourcerequirements) | {"vmiCPUAllocationRatio": 10} | false |
| scratchSpaceStorageClass | Override the storage class used for scratch space during transfer operations. The scratch space storage class is determined in the following order: value of scratchSpaceStorageClass, if that doesn't exist, use the default storage class, if there is no default storage class, use the storage class of the DataVolume, if no storage class specified, use no storage class for scratch space | *string | | false |
| vddkInitImage | VDDK Init Image eventually used to import VMs from external providers | *string | | false |
| vddkInitImage | VDDK Init Image eventually used to import VMs from external providers\n\nDeprecated: please use the Migration Toolkit for Virtualization | *string | | false |
| defaultCPUModel | DefaultCPUModel defines a cluster default for CPU model: default CPU model is set when VMI doesn't have any CPU model. When VMI has CPU model set, then VMI's CPU model is preferred. When default CPU model is not set and VMI's CPU model is not set too, host-model will be set. Default CPU model can be changed when kubevirt is running. | *string | | false |
| defaultRuntimeClass | DefaultRuntimeClass defines a cluster default for the RuntimeClass to be used for VMIs pods if not set there. Default RuntimeClass can be changed when kubevirt is running, existing VMIs are not impacted till the next restart/live-migration when they are eventually going to consume the new default RuntimeClass. | *string | | false |
| obsoleteCPUs | ObsoleteCPUs allows avoiding scheduling of VMs for obsolete CPU models | *[HyperConvergedObsoleteCPUs](#hyperconvergedobsoletecpus) | | false |
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading