Add arm64 description #2819
Add arm64 description #2819
Conversation
kubevirt-bot
added
release-note
|
Skipping CI for Draft Pull Request. |
1 similar comment
|
Skipping CI for Draft Pull Request. |
controllers/operands/kubevirt.go
Outdated
| DefaultARM64OVMFPath = "/usr/share/OVMF" | ||
| DefaultARM64EmulatedMachines = "q35*,pc-q35*" |
There was a problem hiding this comment.
I don't have a clue if these values I have assumed are accurate. Can someone validate so that I can open the PR for review?
There was a problem hiding this comment.
according to this:
https://people.redhat.com/~cohuck/2022/01/05/qemu-machine-types.html
the QEMU machine-type for ARM should be virt.
but it would be better to confirm with virt team. @kbidarkar do you know?
There was a problem hiding this comment.
@acardace could you please confirm arm64 machinetypes?
There was a problem hiding this comment.
qc35 is only available for x86 so I'd avoid setting that. The equivalent of qc35 for arm is virt like @orenc1 mentioned.
There was a problem hiding this comment.
@dharmit for future reference, you can list the machine types supported by qemu by running qemu-system-arm -machine ? (for arm).
Pull Request Test Coverage Report for Build 8265978712Details
💛 - Coveralls |
dharmit
force-pushed
the
fix-cnv-37722
branch
from
adb80b4 to
9cfa7a6
Compare
controllers/operands/kubevirt.go
Outdated
| @@ -37,6 +37,8 @@ const ( | |||
| const ( | |||
| DefaultAMD64OVMFPath = "/usr/share/OVMF" | |||
| DefaultAMD64EmulatedMachines = "q35*,pc-q35*" | |||
| DefaultARM64OVMFPath = "/usr/share/OVMF" | |||
| DefaultARM64EmulatedMachines = "virt-*" | |||
There was a problem hiding this comment.
I think you should have virt*' here, the default one for ARM is called just virt'.
There was a problem hiding this comment.
Ack. Changed. Thanks.
dharmit
force-pushed
the
fix-cnv-37722
branch
from
9cfa7a6 to
fbf9579
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
|
okd-hco-e2e-upgrade-operator-sdk-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
controllers/operands/kubevirt.go
Outdated
| @@ -37,6 +37,8 @@ const ( | |||
| const ( | |||
| DefaultAMD64OVMFPath = "/usr/share/OVMF" | |||
| DefaultAMD64EmulatedMachines = "q35*,pc-q35*" | |||
| DefaultARM64OVMFPath = "/usr/share/OVMF" | |||
There was a problem hiding this comment.
nit: Why do we need this? this is the same value as DefaultAMD64OVMFPath. WDYT about rename DefaultAMD64OVMFPath to drop the specific AMD64 from its name?
There was a problem hiding this comment.
I renamed it but make sanity is failing locally with below error:
git difftool -y --trust-exit-code --extcmd=./hack/diff-csv.sh
--- /tmp/git-blob-X6lOtR/kubevirt.go 2024-03-11 19:21:44.166722178 +0530
+++ controllers/operands/kubevirt.go 2024-03-11 19:08:57.700204965 +0530
@@ -37,5 +37,4 @@
const (
- DefaultAMD64OVMFPath = "/usr/share/OVMF"
+ DefaultOVMFPath = "/usr/share/OVMF"
DefaultAMD64EmulatedMachines = "q35*,pc-q35*"
- DefaultARM64OVMFPath = "/usr/share/OVMF"
DefaultARM64EmulatedMachines = "virt*"
@@ -466,3 +465,3 @@
MachineType: val,
- OVMFPath: DefaultAMD64OVMFPath,
+ OVMFPath: DefaultOVMFPath,
EmulatedMachines: strings.Split(DefaultAMD64EmulatedMachines, ","),
@@ -471,3 +470,3 @@
MachineType: val,
- OVMFPath: DefaultARM64OVMFPath,
+ OVMFPath: DefaultOVMFPath,
EmulatedMachines: strings.Split(DefaultARM64EmulatedMachines, ","),
fatal: external diff died, stopping at controllers/operands/kubevirt.go
make: *** [Makefile:33: sanity] Error 128
I don't understand what's the issue here. 😞
There was a problem hiding this comment.
Looks like it's caused due to uncommitted changes. Committing the changes fixed the error. 🤷🏽♂️
Signed-off-by: Dharmit Shah <[email protected]>
|
|
hco-e2e-operator-sdk-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-operator-sdk-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
okd-hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
okd-hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-operator-sdk-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-aws, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dharmit: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Adds arm64 specific description
Reviewer Checklist
Jira Ticket:
Release note: