Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump google.golang.org/protobuf to v1.33.0 #2842

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Bump google.golang.org/protobuf to v1.33.0 #2842

merged 1 commit into from
Mar 20, 2024

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Mar 14, 2024 •
edited
Loading

Manual gathering of #2838, #2839, #2840 and #2841

Jira Ticket:

None

Release note:

None

@nunnatsa
Bump google.golang.org/protobuf to v1.33.0
dfdaf5a 
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 14, 2024
@nunnatsa nunnatsa requested review from tiraboschi and removed request for machadovilaca and orenc1 March 14, 2024 06:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.3% Duplication on New Code

See analysis details on SonarCloud

This was referenced Mar 14, 2024
Closed
Closed
Closed
Closed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8276661503

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 86.284%
Files with Coverage Reduction New Missed Lines %
controllers/operands/operandHandler.go 1 86.18%
Totals Coverage Status
Change from base Build 8250104486: -0.02%
Covered Lines: 5278
Relevant Lines: 6117
💛 - Coveralls

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 14, 2024

hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws

In response to this:

hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 14, 2024

hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure

In response to this:

hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 14, 2024

hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

In response to this:

hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 14, 2024

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

In response to this:

hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/retest

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 19, 2024

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp
okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-operator-sdk-gcp, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp

In response to this:

okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp
okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 19, 2024

okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-operator-sdk-gcp

In response to this:

okd-hco-e2e-operator-sdk-aws lane succeeded.
/override ci/prow/okd-hco-e2e-operator-sdk-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/retest

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/retest

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 19, 2024

hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/retest hco-e2e-consecutive-operator-sdk-upgrades-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.27
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.28

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.27
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.28

In response to this:

/retest hco-e2e-consecutive-operator-sdk-upgrades-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024

@nunnatsa: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test ci-index-hco-bundle
  • /test ci-index-hco-upgrade-operator-sdk-bundle
  • /test hco-e2e-consecutive-operator-sdk-upgrades-aws
  • /test hco-e2e-consecutive-operator-sdk-upgrades-azure
  • /test hco-e2e-kv-smoke-azure
  • /test hco-e2e-kv-smoke-gcp
  • /test hco-e2e-operator-sdk-aws
  • /test hco-e2e-operator-sdk-azure
  • /test hco-e2e-operator-sdk-gcp
  • /test hco-e2e-upgrade-operator-sdk-aws
  • /test hco-e2e-upgrade-operator-sdk-azure
  • /test hco-e2e-upgrade-prev-operator-sdk-aws
  • /test hco-e2e-upgrade-prev-operator-sdk-azure
  • /test images
  • /test okd-ci-index-hco-bundle
  • /test okd-ci-index-hco-upgrade-operator-sdk-bundle
  • /test okd-hco-e2e-operator-sdk-aws
  • /test okd-hco-e2e-operator-sdk-gcp
  • /test okd-hco-e2e-upgrade-operator-sdk-aws
  • /test okd-hco-e2e-upgrade-operator-sdk-gcp
  • /test okd-images

The following commands are available to trigger optional jobs:

  • /test hco-e2e-operator-sdk-sno-aws
  • /test hco-e2e-operator-sdk-sno-azure
  • /test hco-e2e-upgrade-operator-sdk-sno-aws
  • /test hco-e2e-upgrade-operator-sdk-sno-azure
  • /test hco-e2e-upgrade-prev-operator-sdk-sno-aws
  • /test hco-e2e-upgrade-prev-operator-sdk-sno-azure

Use /test all to run all jobs.

In response to this:

/retest hco-e2e-consecutive-operator-sdk-upgrades-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-consecutive-operator-sdk-upgrades-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-hco-test-utils-image
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.27
  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.28

Use /test all to run the following jobs that were automatically triggered:

  • pull-hyperconverged-cluster-operator-e2e-k8s-1.27
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.28

In response to this:

/test hco-e2e-consecutive-operator-sdk-upgrades-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024 •
edited
Loading

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-operator-sdk-aws dfdaf5a link true /test hco-e2e-operator-sdk-aws
ci/prow/hco-e2e-operator-sdk-azure dfdaf5a link true /test hco-e2e-operator-sdk-azure
ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws dfdaf5a link false /test hco-e2e-upgrade-prev-operator-sdk-sno-aws
ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws dfdaf5a link true /test hco-e2e-upgrade-prev-operator-sdk-aws
ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp dfdaf5a link true /test okd-hco-e2e-upgrade-operator-sdk-gcp
ci/prow/okd-hco-e2e-operator-sdk-gcp dfdaf5a link true /test okd-hco-e2e-operator-sdk-gcp
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure dfdaf5a link false /test hco-e2e-upgrade-operator-sdk-sno-azure
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure dfdaf5a link true /test hco-e2e-consecutive-operator-sdk-upgrades-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nunnatsa
Copy link
Collaborator Author

hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

In response to this:

hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 19, 2024

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

In response to this:

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@nunnatsa
Copy link
Collaborator Author

/retest

@kubevirt-bot kubevirt-bot merged commit 1bddadb into kubevirt:main Mar 20, 2024
36 checks passed
@nunnatsa nunnatsa deleted the bump_google.golang.org/protobuf-1.33.0 branch March 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 approved these changes

@tiraboschi tiraboschi tiraboschi approved these changes

Assignees

@tiraboschi tiraboschi

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nunnatsa @coveralls @hco-bot @kubevirt-bot @tiraboschi @orenc1