Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster-configuration.md: improved allowPostCopy #2872

Merged
merged 1 commit into from
Apr 10, 2024
Merged

cluster-configuration.md: improved allowPostCopy #2872

merged 1 commit into from
Apr 10, 2024

Conversation

dankenigsberg
Copy link
Member

@dankenigsberg dankenigsberg commented Apr 10, 2024 •
edited by tiraboschi
Loading

What this PR does / why we need it:

With kubevirt/kubevirt#11479 we can now drop the warning about VMs reaching an inconsistent state.

/cc @vladikr

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • User Documentation

Jira Ticket:

NONE

Release note:

NONE

@dankenigsberg
cluster-configuration.md: improved allowPostCopy
1819f40 
With kubevirt/kubevirt#11479 we can now drop the warning about VMs reaching an inconsistent state.

Signed-off-by: Dan Kenigsberg <[email protected]>
@kubevirt-bot kubevirt-bot requested a review from vladikr April 10, 2024 13:16
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS labels Apr 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8631928310

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 86.121%
Totals Coverage Status
Change from base Build 8590947767: 0.02%
Covered Lines: 5479
Relevant Lines: 6362
💛 - Coveralls

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 10, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@tiraboschi
Copy link
Member

/retest

@kubevirt-bot kubevirt-bot merged commit 83e88b4 into kubevirt:main Apr 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@vladikr vladikr Awaiting requested review from vladikr

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dankenigsberg @coveralls @tiraboschi @kubevirt-bot