Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nightly test #3206

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix the nightly test #3206

merged 1 commit into from
Dec 12, 2024

Conversation

nunnatsa
Copy link
Collaborator

What this PR does / why we need it:

For some reason, the nightly test is failed to deploy because the HyperConverged never becomes available.

CNAO is now depend on the cert-manager.

Fixed by also deploy the cert-manager.
Release note:

None

For some reason, the nightly test is failed to deploy because the
HyperConverged never becomes available.

CNAO is now depend on the cert-manager.

Fixed by also deploy the cert-manager.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 12, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12299469287

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 71.616%

Files with Coverage Reduction New Missed Lines %
controllers/operands/quickStart.go 1 82.14%
Totals Coverage Status
Change from base Build 12294191085: -0.01%
Covered Lines: 6106
Relevant Lines: 8526

💛 - Coveralls

Copy link
Collaborator

@orenc1 orenc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@kubevirt-bot kubevirt-bot merged commit d2089aa into kubevirt:main Dec 12, 2024
15 checks passed
@nunnatsa nunnatsa deleted the fix-nightly branch December 12, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants