Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selinuxLauncherType to kubevirt configmap #445

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Add selinuxLauncherType to kubevirt configmap #445

merged 1 commit into from
Feb 17, 2020

Conversation

stu-gott
Copy link
Member

@stu-gott stu-gott commented Feb 13, 2020 •
edited
Loading

Add selinuxLauncherType setting to kubevirt-config. This will ensure KubeVirt defaults to use privileged containers: virt_launcher.process can't be added to all runtime environments.

Run Kubevirt's virt-launcher as spc_t

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 13, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stu-gott
Copy link
Member Author

/cc @rmohr

@kubevirt-bot kubevirt-bot requested a review from rmohr February 13, 2020 14:11
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 13, 2020
@tiraboschi
Copy link
Member

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2020
@tiraboschi
Copy link
Member

/approved

@tiraboschi
Copy link
Member

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@tiraboschi tiraboschi merged commit 679dba2 into kubevirt:master Feb 17, 2020
@tiraboschi
Copy link
Member

/cherrypick release-2.3

@kubevirt-bot kubevirt-bot mentioned this pull request Feb 17, 2020
Merged
@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #452

In response to this:

/cherrypick release-2.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@rmohr rmohr Awaiting requested review from rmohr

Assignees

@tiraboschi tiraboschi

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stu-gott @kubevirt-bot @tiraboschi