-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate HCO CRDs from csv-merger and remove templates #453
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
manifest-templator is used to render the manifest for not OLM based deployment; csv-merger is used to render the unified CSV for OLM based deployment. OLM bundles are composed by CSV+CRDs but currently csv-merger renders only the CSV while HCO CRDs (HCO and v2v-vmware ones) are inheredited from manifest-templator execution. This PR will: - extend csv-merger (downstream we use only this one) to independently render hco CRDs - removes /templates which are not used at all Signed-off-by: Simone Tiraboschi <[email protected]>
/test hco-e2e-aws |
/cherrypick release-2.3 |
@tiraboschi: new pull request created: #459 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Generate HCO CRDs from csv-merger and remove templates
manifest-templator is used to render the manifest for
not OLM based deployment; csv-merger is used to render
the unified CSV for OLM based deployment.
OLM bundles are composed by CSV+CRDs but currently
csv-merger renders only the CSV while HCO CRDs (HCO and
v2v-vmware ones) are inheredited from manifest-templator
execution.
This PR will:
independently render hco CRDs
Signed-off-by: Simone Tiraboschi [email protected]