Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate HCO CRDs from csv-merger and remove templates #453

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Generate HCO CRDs from csv-merger and remove templates #453

merged 1 commit into from
Feb 19, 2020

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented Feb 17, 2020

Generate HCO CRDs from csv-merger and remove templates

manifest-templator is used to render the manifest for
not OLM based deployment; csv-merger is used to render
the unified CSV for OLM based deployment.

OLM bundles are composed by CSV+CRDs but currently
csv-merger renders only the CSV while HCO CRDs (HCO and
v2v-vmware ones) are inheredited from manifest-templator
execution.

This PR will:

  • extend csv-merger (downstream we use only this one) to
    independently render hco CRDs
  • removes /templates which are not used at all
- extend csv-merger (downstream we use only this one) to
independently render hco CRDs
- removes /templates which are not used at all

Signed-off-by: Simone Tiraboschi [email protected]

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 17, 2020
@tiraboschi tiraboschi added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tiraboschi
You can assign the PR to them by writing /assign @tiraboschi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

manifest-templator is used to render the manifest for
not OLM based deployment; csv-merger is used to render
the unified CSV for OLM based deployment.

OLM bundles are composed by CSV+CRDs but currently
csv-merger renders only the CSV while HCO CRDs (HCO and
v2v-vmware ones) are inheredited from manifest-templator
execution.

This PR will:
- extend csv-merger (downstream we use only this one) to
independently render hco CRDs
- removes /templates which are not used at all

Signed-off-by: Simone Tiraboschi <[email protected]>
@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@tiraboschi tiraboschi removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 19, 2020
@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 19, 2020
@tiraboschi tiraboschi changed the title Remove templates Generate HCO CRDs from csv-merger and remove templates Feb 19, 2020
@tiraboschi tiraboschi merged commit 4ee0090 into kubevirt:master Feb 19, 2020
@tiraboschi tiraboschi deleted the remove_templates branch February 19, 2020 09:46
@tiraboschi
Copy link
Member Author

/cherrypick release-2.3

@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #459

In response to this:

/cherrypick release-2.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants