Introducing kustomize for HCO deployment #463

orenc1 · 2020-02-19T18:20:30Z

Implementing Kustomization deployment for HCO, aimed to replace the "deploy_marketplace.sh" and "deploy_imageregistry.sh" scripts.

deploy/kustomize/overlays/downstream/hco_cr.yaml

deploy/kustomize/base/01_namespace.yaml

pkg/components/components.go

tiraboschi

Can you please rebase this on master and squash in a single commit?

dankenigsberg · 2020-02-21T13:19:25Z

Can be used as a secondary method for deployment, instead of deploy/deploy_marketplace.sh

There should be only one entry point to deploy the project. You should explain the benefit of kustomize. I don't think there is any point of keeping the existing code - let me know if I am wrong.

djzager · 2020-04-27T13:47:54Z

deploy/kustomize/deploy_kustomize.sh

+
+main() {
+  SCRIPT_DIR="$(dirname "$0")"
+  TARGET_NAMESPACE=$(grep name: $SCRIPT_DIR/namespace.yaml | awk '{print $2}')


The other option is to take theTARGET_NAMESPACE argument (or environment variable) and simply write out the namespace.yaml.

djzager

All of the manifests and deploy_kustomize.sh script look good to me. As far as the README is concerned, you should at least communicate how these manifests would be consumed without the shell script.

djzager · 2020-04-27T15:00:41Z

deploy/kustomize/README.md

@@ -0,0 +1,44 @@
+# Intro


I recommend making the header something like "Kustomize Manifests" and simply describe this directory as manifests for delivering and deploying the HCO via OLM using Kustomize.

Instead of having the "Deploy Modes" as you do below. I recommend that here, you mention that there are two necessary steps to install HCO via OLM in a cluster 1) "delivery" - make OLM aware of HCO and 2) "deploy" - use OLM provided APIs to install HCO.

deploy/kustomize/README.md

djzager

My bad for missing this comment the last round of review, other than the directory structure being included in the readme this LGTM.

djzager · 2020-04-28T19:39:15Z

deploy/kustomize/README.md

+1. **Delivery** - Make HCO recognized and available for the operator-lifecycle-manager (OLM).
+2. **Deployment** - Use OLM provided resources and APIs to deploy HCO on the cluster.
+
+## Directory Tree


To keep from needing to update this readme anytime we modify this directory, let's just drop the directory tree.

tiraboschi · 2020-04-29T16:02:10Z

/test hco-e2e-aws

tiraboschi · 2020-04-29T16:02:16Z

/approve

kubevirt-bot · 2020-04-29T16:02:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi · 2020-04-29T16:03:04Z

ci/prow/hco-e2e-upgrade-aws currently runs on OCP 4.5 and it's going to fail due to a side effect in the fix of https://bugzilla.redhat.com/1825330
It will be addressed on operator-framework/operator-lifecycle-manager#1470 on OLM side.
Temporary ignoring it
/override ci/prow/hco-e2e-upgrade-aws

kubevirt-bot · 2020-04-29T16:03:09Z

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-aws

In response to this:

ci/prow/hco-e2e-upgrade-aws currently runs on OCP 4.5 and it's going to fail due to a side effect in the fix of https://bugzilla.redhat.com/1825330
It will be addressed on operator-framework/operator-lifecycle-manager#1470 on OLM side.
Temporary ignoring it
/override ci/prow/hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2020-04-29T19:00:17Z

/test hco-e2e-aws

Intended to replace deploy_marketplace.sh and deploy_imageregistry.sh scripts. Deployment can be done by two ways: 1. Export relevant env vars, then run the "deploy_kustomize.sh" script using either "marketplace" or "image_registry" arguments. 2. Edit the relevant manifests, then run the overlay for the required HCO deployment combination. Signed-off-by: orenc1 <[email protected]>

… make hco available and install hco, moving quay token and retry_loop functions to different files Signed-off-by: orenc1 <[email protected]>

…ace change using patches, update README file. Signed-off-by: orenc1 <[email protected]>

… resources. Signed-off-by: orenc1 <[email protected]>

Signed-off-by: orenc1 <[email protected]>

djzager

/lgtm

djzager · 2020-04-30T01:14:19Z

/test images

Based on #463 (comment)

/override ci/prow/hco-e2e-upgrade-aws

kubevirt-bot · 2020-04-30T01:14:23Z

@djzager: Overrode contexts on behalf of djzager: ci/prow/hco-e2e-upgrade-aws

In response to this:

/test images

Based on #463 (comment)

/override ci/prow/hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-30T01:16:08Z

@orenc1: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/hco-e2e-upgrade-aws	`fc35ad0`	link	`/test hco-e2e-upgrade-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiraboschi · 2020-04-30T07:43:17Z

/test images

fabiand · 2020-05-07T07:41:29Z

deploy/kustomize/deploy_kustomize.sh

+}
+
+# Deploy HCO and OLM Resources with retries
+retry_loop() {


@dankenigsberg just FYI - this is a retryloop we need to mitigae the not-auto-create-cr

Yes, I'm aware of it. If we auto-create, users with default requirements could avoid this retry_loop. But we cannot avoid in code if we want to support user kustomization of the HCO.cr. We currently have nothing there, but sooner or later, we would.

kubevirt-bot requested review from tiraboschi and yuvalturg February 19, 2020 18:21

djzager reviewed Feb 19, 2020

View reviewed changes

deploy/kustomize/overlays/downstream/hco_cr.yaml Outdated Show resolved Hide resolved

tiraboschi reviewed Feb 21, 2020

View reviewed changes

deploy/kustomize/base/01_namespace.yaml Outdated Show resolved Hide resolved

tiraboschi reviewed Feb 21, 2020

View reviewed changes

pkg/components/components.go Outdated Show resolved Hide resolved

tiraboschi requested changes Feb 21, 2020

View reviewed changes

kubevirt-bot assigned tiraboschi Feb 21, 2020

tiraboschi mentioned this pull request Feb 21, 2020

simple deploy_marketplace.sh #409

Closed

orenc1 force-pushed the kustomize branch from 566ef93 to ac01eed Compare February 23, 2020 10:29

kubevirt-bot added size/L and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Feb 23, 2020

orenc1 force-pushed the kustomize branch from ac01eed to 6698ee2 Compare February 23, 2020 10:32

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/L labels Feb 23, 2020

orenc1 force-pushed the kustomize branch from f91e82c to fe372af Compare February 24, 2020 08:31

orenc1 closed this Feb 24, 2020

orenc1 force-pushed the kustomize branch from fe372af to 65534fb Compare February 24, 2020 08:51

kubevirt-bot added size/XS approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XXL labels Feb 24, 2020

orenc1 reopened this Feb 24, 2020

orenc1 force-pushed the kustomize branch from 6770b39 to d64dac5 Compare April 27, 2020 11:09

djzager reviewed Apr 27, 2020

View reviewed changes

djzager suggested changes Apr 27, 2020

View reviewed changes

djzager suggested changes Apr 28, 2020

View reviewed changes

tiraboschi approved these changes Apr 29, 2020

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020

orenc1 added 6 commits April 29, 2020 23:34

removing templates and variable substitution, differentiating between…

fa3079a

… make hco available and install hco, moving quay token and retry_loop functions to different files Signed-off-by: orenc1 <[email protected]>

Consolidating aux functions to main script, adding support for namesp…

69e120d

…ace change using patches, update README file. Signed-off-by: orenc1 <[email protected]>

Use 'namespace:' in kustomization.yaml to overwrite namespace in base…

498295a

… resources. Signed-off-by: orenc1 <[email protected]>

updating readme file with manual instructions for kustomize deployment

2c82755

Signed-off-by: orenc1 <[email protected]>

Dropping the directory tree from the readme file.

fc35ad0

Signed-off-by: orenc1 <[email protected]>

orenc1 force-pushed the kustomize branch from 39a367f to fc35ad0 Compare April 29, 2020 20:38

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020

djzager approved these changes Apr 30, 2020

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020

kubevirt-bot merged commit 0fe19a6 into kubevirt:master Apr 30, 2020

fabiand reviewed May 7, 2020

View reviewed changes

orenc1 deleted the kustomize branch May 25, 2020 12:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing kustomize for HCO deployment #463

Introducing kustomize for HCO deployment #463

orenc1 commented Feb 19, 2020 •

edited

Loading

tiraboschi left a comment

dankenigsberg commented Feb 21, 2020

djzager Apr 27, 2020

djzager left a comment

djzager Apr 27, 2020

djzager Apr 27, 2020

djzager left a comment

djzager Apr 28, 2020

tiraboschi commented Apr 29, 2020

tiraboschi commented Apr 29, 2020

kubevirt-bot commented Apr 29, 2020

tiraboschi commented Apr 29, 2020

kubevirt-bot commented Apr 29, 2020

tiraboschi commented Apr 29, 2020

djzager left a comment

djzager commented Apr 30, 2020

kubevirt-bot commented Apr 30, 2020

openshift-ci-robot commented Apr 30, 2020 •

edited

Loading

tiraboschi commented Apr 30, 2020

fabiand May 7, 2020

dankenigsberg May 7, 2020

Introducing kustomize for HCO deployment #463

Introducing kustomize for HCO deployment #463

Conversation

orenc1 commented Feb 19, 2020 • edited Loading

tiraboschi left a comment

Choose a reason for hiding this comment

dankenigsberg commented Feb 21, 2020

djzager Apr 27, 2020

Choose a reason for hiding this comment

djzager left a comment

Choose a reason for hiding this comment

djzager Apr 27, 2020

Choose a reason for hiding this comment

djzager Apr 27, 2020

Choose a reason for hiding this comment

djzager left a comment

Choose a reason for hiding this comment

djzager Apr 28, 2020

Choose a reason for hiding this comment

tiraboschi commented Apr 29, 2020

tiraboschi commented Apr 29, 2020

kubevirt-bot commented Apr 29, 2020

tiraboschi commented Apr 29, 2020

kubevirt-bot commented Apr 29, 2020

tiraboschi commented Apr 29, 2020

djzager left a comment

Choose a reason for hiding this comment

djzager commented Apr 30, 2020

kubevirt-bot commented Apr 30, 2020

openshift-ci-robot commented Apr 30, 2020 • edited Loading

tiraboschi commented Apr 30, 2020

fabiand May 7, 2020

Choose a reason for hiding this comment

dankenigsberg May 7, 2020

Choose a reason for hiding this comment

orenc1 commented Feb 19, 2020 •

edited

Loading

openshift-ci-robot commented Apr 30, 2020 •

edited

Loading