BZ 1768751: Add Web UI to rotate-certs.sh #499

mareklibra · 2020-03-16T12:59:07Z

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1768751

Release note:

Fixes BZ 1768751 by including Web UI within `rotate-certs.sh` script.

mareklibra · 2020-03-16T13:01:05Z

@tiraboschi , can you please suggest branch to backport this PR to?
Fixes BZ 1768751, the Web UI is missing in later releases.

mareklibra · 2020-03-16T13:01:14Z

/assign @tiraboschi

mareklibra · 2020-03-16T13:06:18Z

tools/rotate-certs.sh

+formerVersion=$(${_kubectl} get kwebui kubevirt-web-ui -o yaml | grep '  version: '|sed 's/^.*: *\(.*\)$/\1/g')
+echo Detected former Web UI version: ${formerVersion}
+${_kubectl} patch kwebui kubevirt-web-ui --patch '{"spec": {"version": ""}}' --type=merge # undeploy
+sleep 15 # give kubevirt-web-ui-operator enough time to react, but it's usually instant


The web-ui-operator needs to start reconciliation (means undeployment). We do not need to wait till it's finished.

rmohr

The commands don't look like they would work for CNV after 1.4. The script should work for 1.4, 2.0, 2.1 and 2.2.

Can you verify that it can cope with CNV installations without the UI?

mareklibra · 2020-03-16T13:44:11Z

The script should work for 1.4, 2.0, 2.1 and 2.2.

Good point, thank you. This should be valid for 1.4.Z only. I have added check for presence of the corresponding CRD.

rmohr

/lgtm

rmohr · 2020-03-16T13:51:34Z

tools/rotate-certs.sh

+  formerVersion=$(${_kubectl} get kwebui kubevirt-web-ui -o yaml | grep '  version: '|sed 's/^.*: *\(.*\)$/\1/g')
+  echo Detected former Web UI version: ${formerVersion}
+  ${_kubectl} patch kwebui kubevirt-web-ui --patch '{"spec": {"version": ""}}' --type=merge # undeploy
+  sleep 15 # give kubevirt-web-ui-operator enough time to react, but it's usually instant


An unconditional sleep is not really good. You are probably waiting for the ui-deployment to be scaled down or deleted. Could you either just scale down the deployment (which is waiting), or periodically check that the deployment got deleted?

Actually I already had code here checking presence of pods (they are about to be terminated). But found that this is not important. The operator just needs to get time to initiate the reconciliation - to start undeployment. We do not need to wait for this undeployment to be finished.

If really requested, I can add similar check back, either based on status in the CR or pod presence, but it will make the code here harder to read with no/very limited benefit.

What if the undeploy does not happen withing 15 seconds (e.g. temporary error or rbac issue, or whatever)? You would set the version again after 15 seconds. Wouldn't you then risk that no rotation happened at all?

Ok, waiting is added

rmohr · 2020-03-16T13:51:51Z

/lgtm cancel

rmohr

/lgtm
/approve

tools/rotate-certs.sh

tiraboschi · 2020-03-16T16:03:56Z

/lgtm
/approve

kubevirt-bot · 2020-03-16T16:04:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rmohr, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi · 2020-03-16T17:11:55Z

/retest

tiraboschi · 2020-03-16T17:12:12Z

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

tiraboschi · 2020-03-16T21:09:58Z

/retest

tiraboschi · 2020-03-16T21:11:10Z

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

jelkosz · 2020-03-17T06:30:12Z

/retest

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1768751 Signed-off-by: Marek Libra <[email protected]>

Co-Authored-By: David Zager <[email protected]> Signed-off-by: Simone Tiraboschi <[email protected]>

Signed-off-by: Marek Libra <[email protected]>

mareklibra · 2020-03-17T07:50:18Z

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

mareklibra · 2020-03-17T09:36:14Z

/retest

djzager · 2020-03-17T13:19:01Z

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Mar 16, 2020

kubevirt-bot requested review from nunnatsa and yuvalturg March 16, 2020 12:59

kubevirt-bot assigned tiraboschi Mar 16, 2020

mareklibra changed the title ~~Add Web UI to rotate-certs.sh~~ BZ 1768751: Add Web UI to rotate-certs.sh Mar 16, 2020

mareklibra commented Mar 16, 2020

View reviewed changes

rmohr requested changes Mar 16, 2020

View reviewed changes

kubevirt-bot assigned rmohr Mar 16, 2020

mareklibra force-pushed the bz1768751.web-ui.rotateCert branch from 01d1970 to 0e54afe Compare March 16, 2020 13:42

kubevirt-bot added size/S and removed size/XS labels Mar 16, 2020

rmohr requested changes Mar 16, 2020

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020

mareklibra force-pushed the bz1768751.web-ui.rotateCert branch from 0e54afe to 85b7119 Compare March 16, 2020 14:31

rmohr reviewed Mar 16, 2020

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020

djzager suggested changes Mar 16, 2020

View reviewed changes

tools/rotate-certs.sh Outdated Show resolved Hide resolved

kubevirt-bot assigned djzager Mar 16, 2020

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020

tiraboschi reviewed Mar 16, 2020

View reviewed changes

tools/rotate-certs.sh Outdated Show resolved Hide resolved

kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 16, 2020

tiraboschi approved these changes Mar 16, 2020

View reviewed changes

tiraboschi force-pushed the bz1768751.web-ui.rotateCert branch from b847104 to 16710d7 Compare March 16, 2020 16:02

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 16, 2020

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020

mareklibra and others added 2 commits March 17, 2020 08:17

Add Web UI to rotate-certs.sh

ad6bf1f

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1768751 Signed-off-by: Marek Libra <[email protected]>

Update tools/rotate-certs.sh

4e7a986

Co-Authored-By: David Zager <[email protected]> Signed-off-by: Simone Tiraboschi <[email protected]>

mareklibra force-pushed the bz1768751.web-ui.rotateCert branch from 16710d7 to b690c91 Compare March 17, 2020 07:19

kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 17, 2020

rotate-certs.sh: Fix web-ui for set -e environment

85663f8

Signed-off-by: Marek Libra <[email protected]>

mareklibra force-pushed the bz1768751.web-ui.rotateCert branch from b690c91 to 85663f8 Compare March 17, 2020 07:20

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 17, 2020

djzager approved these changes Mar 17, 2020

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020

kubevirt-bot merged commit de56e55 into kubevirt:master Mar 17, 2020

mareklibra mentioned this pull request Mar 19, 2020

fix rotate-certs.sh Web UI namespace #503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BZ 1768751: Add Web UI to rotate-certs.sh #499

BZ 1768751: Add Web UI to rotate-certs.sh #499

mareklibra commented Mar 16, 2020

mareklibra commented Mar 16, 2020

mareklibra commented Mar 16, 2020

mareklibra Mar 16, 2020

rmohr left a comment

mareklibra commented Mar 16, 2020 •

edited

Loading

rmohr left a comment

rmohr Mar 16, 2020

mareklibra Mar 16, 2020

rmohr Mar 16, 2020

mareklibra Mar 16, 2020 •

edited

Loading

rmohr commented Mar 16, 2020

rmohr left a comment

tiraboschi commented Mar 16, 2020

kubevirt-bot commented Mar 16, 2020

tiraboschi commented Mar 16, 2020

tiraboschi commented Mar 16, 2020

tiraboschi commented Mar 16, 2020

tiraboschi commented Mar 16, 2020

jelkosz commented Mar 17, 2020

mareklibra commented Mar 17, 2020

mareklibra commented Mar 17, 2020

djzager commented Mar 17, 2020

BZ 1768751: Add Web UI to rotate-certs.sh #499

BZ 1768751: Add Web UI to rotate-certs.sh #499

Conversation

mareklibra commented Mar 16, 2020

mareklibra commented Mar 16, 2020

mareklibra commented Mar 16, 2020

mareklibra Mar 16, 2020

Choose a reason for hiding this comment

rmohr left a comment

Choose a reason for hiding this comment

mareklibra commented Mar 16, 2020 • edited Loading

rmohr left a comment

Choose a reason for hiding this comment

rmohr Mar 16, 2020

Choose a reason for hiding this comment

mareklibra Mar 16, 2020

Choose a reason for hiding this comment

rmohr Mar 16, 2020

Choose a reason for hiding this comment

mareklibra Mar 16, 2020 • edited Loading

Choose a reason for hiding this comment

rmohr commented Mar 16, 2020

rmohr left a comment

Choose a reason for hiding this comment

tiraboschi commented Mar 16, 2020

kubevirt-bot commented Mar 16, 2020

tiraboschi commented Mar 16, 2020

tiraboschi commented Mar 16, 2020

tiraboschi commented Mar 16, 2020

tiraboschi commented Mar 16, 2020

jelkosz commented Mar 17, 2020

mareklibra commented Mar 17, 2020

mareklibra commented Mar 17, 2020

djzager commented Mar 17, 2020

mareklibra commented Mar 16, 2020 •

edited

Loading

mareklibra Mar 16, 2020 •

edited

Loading