Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump NMO to 0.5.0 #534

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Bump NMO to 0.5.0 #534

merged 1 commit into from
Apr 23, 2020

Conversation

tiraboschi
Copy link
Member

Signed-off-by: Simone Tiraboschi [email protected]

Release note:

Bump NMO to 0.5.0

@tiraboschi tiraboschi requested a review from orenc1 April 20, 2020 08:06
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Apr 20, 2020
@kubevirt-bot kubevirt-bot requested review from rwsu and yuvalturg April 20, 2020 08:07
orenc1
orenc1 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Collaborator

@orenc1 orenc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 20, 2020
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@tiraboschi
Copy link
Member Author

ci/prow/hco-e2e-upgrade-aws currently runs on OCP 4.5 and it's going to fail due to a side effect in the fix of https://bugzilla.redhat.com/1825330
It will be addressed on operator-framework/operator-lifecycle-manager#1470 on OLM side.
Temporary ignoring it
/override ci/prow/hco-e2e-upgrade-aws

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-aws

In response to this:

ci/prow/hco-e2e-upgrade-aws currently runs on OCP 4.5 and it's going to fail due to a side effect in the fix of https://bugzilla.redhat.com/1825330
It will be addressed on operator-framework/operator-lifecycle-manager#1470 on OLM side.
Temporary ignoring it
/override ci/prow/hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ksimon1
Copy link
Member

ksimon1 commented Apr 22, 2020

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@orenc1
Copy link
Collaborator

orenc1 commented Apr 22, 2020

/test hco-e2e-aws

1 similar comment
@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@tiraboschi
Bump NMO to 0.5.0
5364afb 
Signed-off-by: Simone Tiraboschi <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020
@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

3 similar comments
@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 23, 2020 •
edited
Loading

@tiraboschi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-upgrade-aws 5364afb link /test hco-e2e-upgrade-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@tiraboschi
Copy link
Member Author

ci/prow/hco-e2e-upgrade-aws currently runs on OCP 4.5 and it's going to fail due to a side effect in the fix of https://bugzilla.redhat.com/1825330
It will be addressed on operator-framework/operator-lifecycle-manager#1470 on OLM side.
Temporary ignoring it
/override ci/prow/hco-e2e-upgrade-aws

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-aws

In response to this:

ci/prow/hco-e2e-upgrade-aws currently runs on OCP 4.5 and it's going to fail due to a side effect in the fix of https://bugzilla.redhat.com/1825330
It will be addressed on operator-framework/operator-lifecycle-manager#1470 on OLM side.
Temporary ignoring it
/override ci/prow/hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/lgtm

@kubevirt-bot
Copy link
Contributor

@tiraboschi: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator

orenc1 commented Apr 23, 2020

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot merged commit 8163a78 into kubevirt:master Apr 23, 2020
@tiraboschi tiraboschi deleted the nmo_0.5.0 branch August 5, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 approved these changes

@ksimon1 ksimon1 ksimon1 approved these changes

@rwsu rwsu Awaiting requested review from rwsu

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@ksimon1 ksimon1

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiraboschi @kubevirt-bot @ksimon1 @orenc1 @openshift-ci-robot