Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid CatalogSourceConfig #553

Merged
merged 1 commit into from
May 5, 2020
Merged

Avoid CatalogSourceConfig #553

merged 1 commit into from
May 5, 2020

Conversation

tiraboschi
Copy link
Member

CatalogSourceConfig has been removed (not deprecated) on
OLM side with
operator-framework/operator-marketplace#302
Avoid using it and use only CatalogSource in all the
deployment scripts.

Signed-off-by: Simone Tiraboschi [email protected]

Release note:

Use only CatalogSource instead of CatalogSourceConfig

@tiraboschi tiraboschi requested review from djzager, orenc1 and nunnatsa May 1, 2020 07:52
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels May 1, 2020
@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/retest

djzager
djzager reviewed May 1, 2020
View reviewed changes
Copy link
Contributor

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments. Otherwise it looks good.

deploy/deploy_marketplace.sh Outdated Show resolved Hide resolved
deploy/kustomize/README.md Outdated Show resolved Hide resolved
@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2020
@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 4, 2020
@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1
/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.15.1
/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@orenc1
Copy link
Collaborator

orenc1 commented May 4, 2020

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2020
@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

2 similar comments
@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@nunnatsa
Copy link
Collaborator

nunnatsa commented May 5, 2020

/test hco-e2e-aws

@nunnatsa
Copy link
Collaborator

nunnatsa commented May 5, 2020

/test hco-e2e-aws

@orenc1
Copy link
Collaborator

orenc1 commented May 5, 2020

ci/prow/hco-e2e-aws

@tiraboschi
Avoid CatalogSourceConfig
432f4af 
CatalogSourceConfig has been removed (not deprecated) on
OLM side with
operator-framework/operator-marketplace#302
Avoid using it and use only OperatorSource in all the
marketplace based deployment scripts.
The OperatorSource will implicitly trigger the creation of
a CatalogSource with the same name.

Signed-off-by: Simone Tiraboschi <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@orenc1
Copy link
Collaborator

orenc1 commented May 5, 2020

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@kubevirt-bot kubevirt-bot merged commit 2293a1a into kubevirt:master May 5, 2020
@tiraboschi tiraboschi deleted the no_csc branch May 5, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@orenc1 orenc1 orenc1 approved these changes

@djzager djzager djzager approved these changes

Assignees

@djzager djzager

@orenc1 orenc1

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tiraboschi @openshift-ci-robot @orenc1 @kubevirt-bot @nunnatsa @djzager