Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade - check components #584

Merged
merged 1 commit into from
May 28, 2020
Merged

Upgrade - check components #584

merged 1 commit into from
May 28, 2020

Conversation

nunnatsa
Copy link
Collaborator

Release note:

HCO, during upgrade, checks the upgrade status of the underline components.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 21, 2020
@nunnatsa nunnatsa changed the title Track operator versions Upgrade - check components May 21, 2020
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa nunnatsa force-pushed the track_operator_versions branch 2 times, most recently from c45b001 to df37514 Compare May 25, 2020 07:15
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-upgrade-aws

@nunnatsa nunnatsa force-pushed the track_operator_versions branch from df37514 to 8f43c89 Compare May 25, 2020 13:26
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-upgrade-aws

/test hco-e2e-aws

@nunnatsa nunnatsa force-pushed the track_operator_versions branch from 8f43c89 to a939969 Compare May 26, 2020 06:31
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-upgrade-aws

/test hco-e2e-aws

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-upgrade-aws

/test hco-e2e-aws

@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

/hold
Waiting for a new CDI release with a fix to the "Missing ObservedVersion field in Some Cases" issue

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@tiraboschi tiraboschi mentioned this pull request May 26, 2020
Merged
@nunnatsa nunnatsa force-pushed the track_operator_versions branch from d61fbce to 7da1989 Compare May 26, 2020 10:34
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2020
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa nunnatsa force-pushed the track_operator_versions branch from dc9a4ca to 4d6c567 Compare May 27, 2020 06:09
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2020
@nunnatsa nunnatsa force-pushed the track_operator_versions branch from 4d6c567 to 991fe50 Compare May 27, 2020 12:23
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@tiraboschi tiraboschi mentioned this pull request May 27, 2020
Closed
@tiraboschi tiraboschi mentioned this pull request May 27, 2020
Closed
@nunnatsa
Copy link
Collaborator Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2020
@tiraboschi @nunnatsa
Track operator versions as env variables
926c5ed 
in HCO deployment to enable upgrade status checks

during upgrade, check each component if its upgrade is done

temporary remove upgrade check for CDI, because of a CDI bug

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@nunnatsa nunnatsa force-pushed the track_operator_versions branch from 78a9ea3 to 926c5ed Compare May 28, 2020 06:01
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-upgrade-aws

@tiraboschi
Copy link
Member

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@kubevirt-bot kubevirt-bot merged commit 07c3322 into kubevirt:master May 28, 2020
@nunnatsa nunnatsa deleted the track_operator_versions branch May 28, 2020 08:56
@tiraboschi tiraboschi mentioned this pull request May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@djzager djzager Awaiting requested review from djzager

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunnatsa @tiraboschi @kubevirt-bot