Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Avoid sspv1.KubevirtNodeLabellerBundle and cpu-plugin on SSP operator" #591

Merged
merged 1 commit into from
May 25, 2020

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented May 25, 2020

Revert "Avoid sspv1.KubevirtNodeLabellerBundle and cpu-plugin (#583)"

This reverts commit 42ffb74.

This feature is not ready and it's going to be reverted on SSP
side with kubevirt/kubevirt-ssp-operator#170
Update HCO due to that.

Signed-off-by: Simone Tiraboschi [email protected]

Reverts kubevirt/hyperconverged-cluster-operator#583

@tiraboschi tiraboschi requested a review from ksimon1 May 25, 2020 08:16
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L labels May 25, 2020
Copy link
Member

@ksimon1 ksimon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2020
This reverts commit 42ffb74.

This feature is not ready and it's going to be reverted on SSP
side with kubevirt/kubevirt-ssp-operator#170
Update HCO due to that.

Signed-off-by: Simone Tiraboschi <[email protected]>
@tiraboschi tiraboschi force-pushed the revert-583-no_kubevirtnodelabellerbundles_ssp branch from ccf0a5c to 3a41513 Compare May 25, 2020 09:24
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels May 25, 2020
@tiraboschi
Copy link
Member Author

/ok-to-test

@kubevirt-bot kubevirt-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 25, 2020
@orenc1
Copy link
Collaborator

orenc1 commented May 25, 2020

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2020
@kubevirt-bot kubevirt-bot merged commit 8b9191c into master May 25, 2020
@tiraboschi tiraboschi deleted the revert-583-no_kubevirtnodelabellerbundles_ssp branch May 25, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants