Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VM Import Operator to bump-bot + compare versions fix #596

Merged
merged 1 commit into from
May 29, 2020
Merged

Add VM Import Operator to bump-bot + compare versions fix #596

merged 1 commit into from
May 29, 2020

Conversation

orenc1
Copy link
Collaborator

@orenc1 orenc1 commented May 27, 2020

  1. Adding the new VM Import Operator to be sampled and bumped by the bot.
  2. Fixing an issue where the most recent component version is not tagged as "latest" - in such case, the greater version number will win.

Signed-off-by: orenc1 [email protected]

Release note:

Add VM Import Operator to Bump-Bot

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels May 27, 2020
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@tiraboschi
Copy link
Member

/approve
/lgtm

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@orenc1
Copy link
Collaborator Author

orenc1 commented May 27, 2020

/hold
need to refactor to support releases with non-numerical tags (e.g. "rc")

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@orenc1 orenc1 force-pushed the bot_compare_versions branch from 9a33f8a to 2b8f433 Compare May 27, 2020 20:32
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@orenc1
Copy link
Collaborator Author

orenc1 commented May 27, 2020 •
edited
Loading

/hold
need to refactor to support releases with non-numerical tags (e.g. "rc")

Semvers with letters are now supported.

@orenc1
Copy link
Collaborator Author

orenc1 commented May 29, 2020

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@orenc1: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator Author

orenc1 commented May 29, 2020

/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2020
@orenc1
Copy link
Collaborator Author

orenc1 commented May 29, 2020

/hold cancel

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2020
@kubevirt-bot kubevirt-bot merged commit fe30235 into kubevirt:master May 29, 2020
@orenc1 orenc1 deleted the bot_compare_versions branch April 25, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@djzager djzager Awaiting requested review from djzager

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orenc1 @tiraboschi @kubevirt-bot @openshift-ci-robot