Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug 1839837 were HCO updates fails duo to previous update. #609

Merged
merged 5 commits into from
Jun 1, 2020
Merged

Fix bug 1839837 were HCO updates fails duo to previous update. #609

merged 5 commits into from
Jun 1, 2020

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented May 31, 2020 •
edited
Loading

This is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1839837

The reconcile is now a wrapper to the new doReconcile method. The Reconcile wrapper is the only place HCO update the CR.

Signed-off-by: Nahshon Unna-Tsameret [email protected]

fix bug 1839837 - Avoid errors in hco-operator log when it is trying to update its resource twice in a single reconciliation loop
https://bugzilla.redhat.com/show_bug.cgi?id=1839837

@nunnatsa
Fix bug were HCO updates fails dou to previous update.
0c57381 
This is a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1839837

The reconcile is now a wrapper to the new doReconcile method. The Reconcile wrapper is the only place HCO update the CR.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 31, 2020
@kubevirt-bot kubevirt-bot requested review from orenc1 and yuvalturg May 31, 2020 07:34
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

/test hco-e2e-upgrade-aws

@nunnatsa
Fix failed tests
5dcd641 
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@orenc1
Copy link
Collaborator

orenc1 commented May 31, 2020

/retest

@nunnatsa
Copy link
Collaborator Author

/hold

Not sure about this fix

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2020
@nunnatsa
Copy link
Collaborator Author

/check-dco

@nunnatsa
Copy link
Collaborator Author

/check-cla

@nunnatsa nunnatsa changed the title Fix bug were HCO updates fails dou to previous update. Fix bug 1839837 were HCO updates fails duo to previous update. May 31, 2020
@nunnatsa
Copy link
Collaborator Author

/bugzilla refresh

@nunnatsa
Copy link
Collaborator Author

/lint

@nunnatsa
Add documentation
5406139 
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Copy link
Collaborator Author

/test travis-ci/pr

@openshift-ci-robot
Copy link
Collaborator

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test travis-ci/pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/test images

@nunnatsa
Add some more documentation
ba9f8b2 
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jun 1, 2020

/cc @djzager - please review.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jun 1, 2020

/test images

@nunnatsa
Fix code review comment
a876e69 
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added size/L and removed size/M labels Jun 1, 2020
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jun 1, 2020

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jun 1, 2020

/retest

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2020
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jun 1, 2020

/retest

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jun 1, 2020

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

@openshift-ci-robot
Copy link
Collaborator

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-upgrade-aws
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-ocp-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jun 1, 2020

/retest

@kubevirt-bot kubevirt-bot merged commit 5a8cb87 into kubevirt:master Jun 1, 2020
@nunnatsa nunnatsa deleted the avoid-multiple-updates branch June 1, 2020 18:21
@tiraboschi
Copy link
Member

/cherry-pick release-2.4

@kubevirt-bot kubevirt-bot mentioned this pull request Jun 1, 2020
Merged
@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #611

In response to this:

/cherry-pick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nunnatsa @ovirt-infra @orenc1 @openshift-ci-robot @tiraboschi @kubevirt-bot