-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-2.4] Add missing fields, required by OLM #622
[release-2.4] Add missing fields, required by OLM #622
Conversation
All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add the `status.version` field to HCO CR * Add the `labels['app']` field to HCO CR Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fix bug 1716329
status.version
field to HCO CR.labels['app']
field to HCO CR.Note: The
status.phase
field is not required anymore.Signed-off-by: Nahshon Unna-Tsameret [email protected]
Release note: