Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.4] Add missing fields, required by OLM #622

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[release-2.4] Add missing fields, required by OLM #622

merged 1 commit into from
Jun 4, 2020

Conversation

tiraboschi
Copy link
Member

Fix bug 1716329

  • Add the status.version field to HCO CR.
  • Add the labels['app'] field to HCO CR.

Note: The status.phase field is not required anymore.

Signed-off-by: Nahshon Unna-Tsameret [email protected]

Release note:

Fix bug 1716329: https://bugzilla.redhat.com/show_bug.cgi?id=1716329

@tiraboschi tiraboschi requested review from orenc1 and nunnatsa June 4, 2020 06:33
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Jun 4, 2020
@kubevirt-bot kubevirt-bot requested a review from rwsu June 4, 2020 06:34
@ovirt-infra
Copy link

All tests passed

Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
* Add the `status.version` field to HCO CR
* Add the `labels['app']` field to HCO CR

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@ovirt-infra
Copy link

All tests passed

Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@kubevirt-bot kubevirt-bot merged commit 5d769e1 into kubevirt:release-2.4 Jun 4, 2020
@tiraboschi tiraboschi deleted the add-missing-fields_release_2.4 branch August 5, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants