Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CDI to v1.19.0 #648

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Bump CDI to v1.19.0 #648

merged 1 commit into from
Jun 21, 2020

Conversation

github-actions[bot]
Copy link
Contributor

Bump CDI to v1.19.0
Executed by HCO Release-Bumper Bot.

Bump CDI to v1.19.0

Signed-off-by: hco_bump_bot <[email protected]>
@github-actions github-actions bot requested review from orenc1 and tiraboschi June 21, 2020 05:11
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 21, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jun 21, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 21, 2020
@kubevirt-bot kubevirt-bot requested review from rthallisey and rwsu June 21, 2020 05:11
@kubevirt-bot
Copy link
Contributor

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2020
@nunnatsa
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2020
@nunnatsa
Copy link
Collaborator

/test images

1 similar comment
@orenc1
Copy link
Collaborator

orenc1 commented Jun 21, 2020

/test images

@orenc1
Copy link
Collaborator

orenc1 commented Jun 21, 2020

/lgtm

@kubevirt-bot kubevirt-bot merged commit eb839eb into master Jun 21, 2020
@orenc1
Copy link
Collaborator

orenc1 commented Jun 21, 2020

/cherry-pick release-2.4

@kubevirt-bot
Copy link
Contributor

@orenc1: #648 failed to apply on top of branch "release-2.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	deploy/olm-catalog/kubevirt-hyperconverged/1.2.0/kubevirt-hyperconverged-operator.v1.2.0.clusterserviceversion.yaml
M	deploy/operator.yaml
M	hack/config
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging hack/config
Auto-merging deploy/operator.yaml
Auto-merging deploy/olm-catalog/kubevirt-hyperconverged/1.1.0/kubevirt-hyperconverged-operator.v1.1.0.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in deploy/olm-catalog/kubevirt-hyperconverged/1.1.0/kubevirt-hyperconverged-operator.v1.1.0.clusterserviceversion.yaml
Patch failed at 0001 Bump CDI to v1.19.0

In response to this:

/cherry-pick release-2.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 pushed a commit to orenc1/hyperconverged-cluster-operator that referenced this pull request Jun 21, 2020
Signed-off-by: hco_bump_bot <[email protected]>

Co-authored-by: GitHub <[email protected]>
kubevirt-bot pushed a commit that referenced this pull request Jun 22, 2020
Signed-off-by: hco_bump_bot <[email protected]>

Co-authored-by: GitHub <[email protected]>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub <[email protected]>
@orenc1 orenc1 deleted the bump_CDI_v1.19.0 branch June 22, 2020 09:54
orenc1 added a commit to orenc1/hyperconverged-cluster-operator that referenced this pull request Jun 24, 2020
Signed-off-by: orenc1 <[email protected]>

This reverts commit 61124ad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants