Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running HCO locally, for development and debug #654

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Allow running HCO locally, for development and debug #654

merged 2 commits into from
Jun 30, 2020

Conversation

nunnatsa
Copy link
Collaborator

Signed-off-by: Nahshon Unna-Tsameret [email protected]

Release note:

For development and debug, it is now possible to run HCO locally, from an IDE.

@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 22, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Jun 22, 2020
@nunnatsa nunnatsa requested review from orenc1 and removed request for yuvalturg June 22, 2020 12:14
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Copy link
Collaborator Author

/test images

@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa
Copy link
Collaborator Author

/retest

1 similar comment
@nunnatsa
Copy link
Collaborator Author

/retest

@nunnatsa nunnatsa closed this Jun 24, 2020
@nunnatsa nunnatsa reopened this Jun 24, 2020
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-aws

@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jun 24, 2020 •
edited
Loading

/hold

first we'll complete 2.4 tasks

@nunnatsa
Copy link
Collaborator Author

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@nunnatsa
fix make_local.sh for K8s
35cc6ea 
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@nunnatsa
Copy link
Collaborator Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2020
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@tiraboschi
Copy link
Member

/lgtm

@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@kubevirt-bot kubevirt-bot merged commit e304edb into kubevirt:master Jun 30, 2020
@nunnatsa nunnatsa deleted the allow-local-run branch June 30, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nunnatsa @ovirt-infra @tiraboschi @kubevirt-bot