Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deleting KubeVirt Priority Class #670

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Avoid deleting KubeVirt Priority Class #670

merged 1 commit into from
Jul 2, 2020

Conversation

tiraboschi
Copy link
Member

Avoid deleting KubeVirt Priority Class

KV Priority Class is needed to start virt-operator
but OLM is currently not able to create it so HCO
is trying to create it ASAP.
With #669
we are trying to create it as soon as HCO starts.
But, for the same reason, we should not trying to
delete it it when the user deletes HCO CR because
virt-operator should continue running even if HCO
CR got deleted.
In the past we were trying to delete the priority
class but we was failing on that just because we forgot
to set app label on that and componentResourceRemoval is
explictly checking for that before really deleting.

Release note:

Avoid deleting KV Priority Class when the user deletes HCO CR

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Jun 30, 2020
@kubevirt-bot kubevirt-bot requested a review from rwsu June 30, 2020 11:59
@ovirt-infra
Copy link

All tests passed

@yuvalturg
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 30, 2020
@ovirt-infra
Copy link

All tests passed

2 similar comments
@ovirt-infra
Copy link

All tests passed

@ovirt-infra
Copy link

All tests passed

@tiraboschi
Avoid deleting KubeVirt Priority Class
6f9898d 
KV Priority Class is needed to start virt-operator
but OLM is currently not able to create it so HCO
is trying to create it ASAP.
With #669
we are trying to create it as soon as HCO starts.
But, for the same reason, we should not trying to
delete it it when the user deletes HCO CR because
virt-operator should continue running even if HCO
CR got deleted.
In the past we were trying to delete the priority
class but we was failing on that just because we forgot
to set app label on that and componentResourceRemoval is
explictly checking for that before really deleting.

Signed-off-by: Simone Tiraboschi <[email protected]>
@ovirt-infra
Copy link

All tests passed

@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa
nunnatsa approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@kubevirt-bot kubevirt-bot merged commit 5200886 into kubevirt:master Jul 2, 2020
@tiraboschi tiraboschi deleted the avoid_deleting_pc branch August 5, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@danielBelenky danielBelenky Awaiting requested review from danielBelenky

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@yuvalturg yuvalturg

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiraboschi @ovirt-infra @yuvalturg @kubevirt-bot @nunnatsa