Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to v1beta1 #695

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Move to v1beta1 #695

merged 2 commits into from
Jul 21, 2020

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Jul 8, 2020

Start github.com/kubevirt/hyperconverged-cluster-operator/pkg/apis/hco/v1beta1 as copy of github.com/kubevirt/hyperconverged-cluster-operator/pkg/apis/hco/v1alpha1.

Use github.com/kubevirt/hyperconverged-cluster-operator/pkg/apis/hco/v1beta1 internally.

Signed-off-by: Nahshon Unna-Tsameret [email protected]

Release note:

new version for github.com/kubevirt/hyperconverged-cluster-operator/pkg/apis/hco - v1beta1

@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 8, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Jul 8, 2020
@kubevirt-bot kubevirt-bot requested review from djzager and rwsu July 8, 2020 13:19
@nunnatsa nunnatsa changed the title Move to v1beta1 WIP - Move to v1beta1 Jul 8, 2020
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2020
@nunnatsa
Copy link
Collaborator Author

nunnatsa commented Jul 8, 2020

/hold

WIP

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@tiraboschi tiraboschi mentioned this pull request Jul 13, 2020
Merged
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2020
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2020
@nunnatsa nunnatsa force-pushed the move-to-v1beta1 branch 2 times, most recently from 6f44d70 to 7457780 Compare July 15, 2020 07:17
@nunnatsa
Copy link
Collaborator Author

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

@openshift-ci-robot
Copy link
Collaborator

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test hco-e2e-aws
  • /test hco-e2e-azure
  • /test hco-e2e-upgrade-aws
  • /test hco-e2e-upgrade-azure
  • /test hco-e2e-upgrade-prev-aws
  • /test hco-e2e-upgrade-prev-azure
  • /test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa force-pushed the move-to-v1beta1 branch 6 times, most recently from 52cce9d to 1d98ed3 Compare July 16, 2020 06:53
@nunnatsa nunnatsa changed the title WIP - Move to v1beta1 Move to v1beta1 Jul 20, 2020
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2020
nunnatsa added 2 commits July 21, 2020 08:20
@nunnatsa
Move to v1beta1
848623b 
Start github.com/kubevirt/hyperconverged-cluster-operator/pkg/apis/hco/v1beta1 as copy of github.com/kubevirt/hyperconverged-cluster-operator/pkg/apis/hco/v1alpha1.

Use github.com/kubevirt/hyperconverged-cluster-operator/pkg/apis/hco/v1beta1 internally.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@nunnatsa
change api version on usage
5818807 
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@nunnatsa
Copy link
Collaborator Author

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@kubevirt-bot kubevirt-bot merged commit 0878c67 into kubevirt:master Jul 21, 2020
@nunnatsa nunnatsa deleted the move-to-v1beta1 branch July 21, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@djzager djzager Awaiting requested review from djzager

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nunnatsa @ovirt-infra @openshift-ci-robot @tiraboschi @kubevirt-bot