Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump HPP to v0.5.1 and HPPO to v0.5.2 #721

Merged
merged 3 commits into from
Aug 2, 2020
Merged

Bump HPP to v0.5.1 and HPPO to v0.5.2 #721

merged 3 commits into from
Aug 2, 2020

Conversation

orenc1
Copy link
Collaborator

@orenc1 orenc1 commented Jul 23, 2020

Signed-off-by: orenc1 [email protected]

Release note:

Bump HPP & HPPO to v0.5.0

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Jul 23, 2020
@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2020
@orenc1 orenc1 force-pushed the bump_hpp_v0.5.0 branch from 18e0a0f to 1c2203b Compare July 27, 2020 07:49
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2020
@orenc1 orenc1 changed the title Bump HPP and HPPO to v0.5.0 Bump HPP to v0.5.1 and HPPO to v0.5.0 Jul 27, 2020
orenc1
orenc1 commented Jul 27, 2020
View reviewed changes
hack/build-manifests.sh
@@ -229,7 +229,7 @@ EOM
# Write HCO CRDs
(cd ${PROJECT_ROOT}/tools/csv-merger/ && go build)
hco_crds=${TEMPDIR}/hco.crds.yaml
${PROJECT_ROOT}/tools/csv-merger/csv-merger --api-sources=${PROJECT_ROOT}/pkg/apis/... --output-mode=CRDs > $hco_crds
(cd ${PROJECT_ROOT} && ${PROJECT_ROOT}/tools/csv-merger/csv-merger --api-sources=${PROJECT_ROOT}/pkg/apis/... --output-mode=CRDs > $hco_crds)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this change.
Otherwise csv-merger exits with cannot import absolute path

@yuvalturg
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@orenc1
Copy link
Collaborator Author

orenc1 commented Jul 27, 2020

Hi @awels ,
The HPP CRD is not compliant with apiextensions.k8s.io/v1
Could you please check and fix it?
the relevant code is here:
https://github.com/kubevirt/hostpath-provisioner-operator/blob/master/tools/helper/helper.go#L131

Thanks

 The CustomResourceDefinition "hostpathprovisioners.hostpathprovisioner.kubevirt.io" is invalid: 
* spec.validation.openAPIV3Schema.properties[status].properties[conditions].items: Required value: must be specified
* spec.validation.openAPIV3Schema.properties[status].type: Required value: must not be empty for specified object fields

@awels
Copy link
Member

awels commented Jul 27, 2020

Ugh, forgot to sync the csv generator, the yaml is correct, let me sync them.

@awels
Copy link
Member

awels commented Jul 27, 2020

kubevirt/hostpath-provisioner-operator#79 fixes the CRD in helper.go

@awels
Copy link
Member

awels commented Jul 27, 2020

https://github.com/kubevirt/hostpath-provisioner-operator/releases/tag/v0.5.1 should have it fixed. if you update to use operator 0.5.1

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@orenc1
Copy link
Collaborator Author

orenc1 commented Jul 27, 2020

https://github.com/kubevirt/hostpath-provisioner-operator/releases/tag/v0.5.1 should have it fixed. if you update to use operator 0.5.1

done, thanks

@orenc1 orenc1 changed the title Bump HPP to v0.5.1 and HPPO to v0.5.0 Bump HPP and HPPO to v0.5.1 Jul 27, 2020
@orenc1
Copy link
Collaborator Author

orenc1 commented Jul 27, 2020

/retest

3 similar comments
@orenc1
Copy link
Collaborator Author

orenc1 commented Jul 28, 2020

/retest

@orenc1
Copy link
Collaborator Author

orenc1 commented Jul 28, 2020

/retest

@nunnatsa
Copy link
Collaborator

/retest

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2020
@nunnatsa
Copy link
Collaborator

/rebase

This was referenced Jul 30, 2020
Closed
Closed
@orenc1
update HPP to 0.5.1
3eace53 
Signed-off-by: orenc1 <[email protected]>
@orenc1 orenc1 force-pushed the bump_hpp_v0.5.0 branch from 678ba82 to a72d76d Compare July 30, 2020 15:24
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2020
@awels
Copy link
Member

awels commented Jul 30, 2020 •
edited
Loading

Could it be that the failures are because from v1alpha1 to v1beta1, I changed one of the fields from a string to a boolean? I did remove the alpha api completely, since HCO wasn't managing it. Looks like something is looking for alpha api?

@orenc1
Copy link
Collaborator Author

orenc1 commented Jul 30, 2020

Could it be that the failures are because from v1alpha1 to v1beta1, I changed one of the fields from a string to a boolean? I did remove the alpha api completely, since HCO wasn't managing it. Looks like something is looking for alpha api?

Yes, looks like the olm registry container is searching for hostpathprovisioner.kubevirt.io/v1alpha1/HostPathProvisioner in the bundle, and can't find it.

@awels
Copy link
Member

awels commented Jul 30, 2020

I guess I am stuck keeping it around for a bit....

@awels
Copy link
Member

awels commented Jul 30, 2020

kubevirt/hostpath-provisioner-operator#82 once merged I will make new release v0.5.2

@awels
Copy link
Member

awels commented Jul 31, 2020

I created new 0.5.2 release that should have alpha api in it again.

@orenc1 orenc1 force-pushed the bump_hpp_v0.5.0 branch from a72d76d to 773692d Compare July 31, 2020 18:00
@orenc1 orenc1 changed the title Bump HPP and HPPO to v0.5.1 Bump HPP to v0.5.1 and HPPO to v0.5.2 Jul 31, 2020
@orenc1
Copy link
Collaborator Author

orenc1 commented Aug 2, 2020

/retest

@nunnatsa
Copy link
Collaborator

nunnatsa commented Aug 2, 2020

/test hco-e2e-upgrade-prev-azure
/test hco-e2e-upgrade-aws

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-azure
/test hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa
nunnatsa approved these changes Aug 2, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2020
@kubevirt-bot kubevirt-bot merged commit 0a00466 into kubevirt:master Aug 2, 2020
@nunnatsa nunnatsa mentioned this pull request Aug 2, 2020
Closed
@orenc1 orenc1 deleted the bump_hpp_v0.5.0 branch March 15, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@djzager djzager Awaiting requested review from djzager

@rthallisey rthallisey Awaiting requested review from rthallisey

Assignees

@yuvalturg yuvalturg

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orenc1 @ovirt-infra @yuvalturg @awels @nunnatsa @kubevirt-bot