Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sed path in deploy_kustomize.sh #727

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Update sed path in deploy_kustomize.sh #727

merged 1 commit into from
Jul 28, 2020

Conversation

colonwq
Copy link
Contributor

@colonwq colonwq commented Jul 27, 2020

PR #711 added to sed calls. Both are relative to the base
of the git directory. The calls fail when the deploy_kustomize.sh
script is ran from the kustomize directory.

Updated sed calls to use the $SCRIPT_DIR parameter

Signed-off-by: Keith Schincke [email protected]

Release note:

NONE

@kschinck
Update sed path in deploy_kustomize.sh
da71a04 
PR kubevirt#711 added to sed calls. Both are relative to the base
of the git directory. The calls fail when the deploy_kustomize.sh
script is ran from the kustomize directory.

Updated sed calls to use the $SCRIPT_DIR parameter

Signed-off-by: Keith Schincke <[email protected]>
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 27, 2020
@openshift-ci-robot
Copy link
Collaborator

Hi @colonwq. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

Hi @colonwq. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@colonwq colonwq mentioned this pull request Jul 27, 2020
Closed
@orenc1
Copy link
Collaborator

orenc1 commented Jul 28, 2020

Thanks for the correction, @colonwq

/ok-to-test

@kubevirt-bot kubevirt-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 28, 2020
@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2020
@orenc1
Copy link
Collaborator

orenc1 commented Jul 28, 2020

/retest

@openshift-ci-robot
Copy link
Collaborator

@colonwq: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-upgrade-azure da71a04 link /test hco-e2e-upgrade-azure
ci/prow/hco-e2e-azure da71a04 link /test hco-e2e-azure
ci/prow/hco-e2e-upgrade-prev-azure da71a04 link /test hco-e2e-upgrade-prev-azure
ci/prow/hco-e2e-upgrade-prev-aws da71a04 link /test hco-e2e-upgrade-prev-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt kubevirt deleted a comment from kubevirt-bot Jul 28, 2020
@orenc1
Copy link
Collaborator

orenc1 commented Jul 28, 2020

The changes in this PR do not affect CI execution. Overriding failed tests.
/override ci/prow/hco-e2e-azure
/override ci/prow/hco-e2e-upgrade-azure
/override ci/prow/hco-e2e-upgrade-prev-aws
/override ci/prow/hco-e2e-upgrade-prev-azure

@orenc1
Copy link
Collaborator

orenc1 commented Jul 28, 2020

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@kubevirt-bot
Copy link
Contributor

@orenc1: Overrode contexts on behalf of orenc1: ci/prow/hco-e2e-azure, ci/prow/hco-e2e-upgrade-azure, ci/prow/hco-e2e-upgrade-prev-aws, ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

The changes in this PR do not affect CI execution. Overriding failed tests.
/override ci/prow/hco-e2e-azure
/override ci/prow/hco-e2e-upgrade-azure
/override ci/prow/hco-e2e-upgrade-prev-aws
/override ci/prow/hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: orenc1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@kubevirt-bot kubevirt-bot merged commit a97db1a into kubevirt:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rthallisey rthallisey Awaiting requested review from rthallisey

@tiraboschi tiraboschi Awaiting requested review from tiraboschi

Assignees

@orenc1 orenc1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@colonwq @ovirt-infra @openshift-ci-robot @kubevirt-bot @orenc1 @kschinck