Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider NMO as an external operator #737

Merged
merged 1 commit into from
Aug 11, 2020
Merged

consider NMO as an external operator #737

merged 1 commit into from
Aug 11, 2020

Conversation

tiraboschi
Copy link
Member

We are going to consume NMO as an external operator
just as a dependency at OLM level.

TODO: get NMO in CI from https://quay.io/repository/kubevirt/node-maintenance-operator-index:latest index image

Signed-off-by: Simone Tiraboschi [email protected]

Release note:

Consider NMO as an external operator

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Aug 6, 2020
@kubevirt-bot kubevirt-bot requested a review from djzager August 6, 2020 14:24
@ovirt-infra
Copy link

All tests passed

@slintes
Copy link
Contributor

slintes commented Aug 6, 2020

there it goes... thanks! 👍

@ovirt-infra
Copy link

All tests passed

2 similar comments
@ovirt-infra
Copy link

All tests passed

@ovirt-infra
Copy link

All tests passed

@tiraboschi
Copy link
Member Author

/retest

@tiraboschi
Copy link
Member Author

/test hco-e2e-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator

nunnatsa commented Aug 9, 2020

/retest

@tiraboschi
Copy link
Member Author

/test hco-e2e-upgrade-aws
/test hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-aws
/test hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ovirt-infra
Copy link

All tests passed

1 similar comment
@ovirt-infra
Copy link

All tests passed

@tiraboschi
Copy link
Member Author

/test images

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test hco-e2e-aws

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi tiraboschi changed the title wip: consider NMO as an external operator consider NMO as an external operator Aug 11, 2020
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2020
@ovirt-infra
Copy link

All tests passed

@orenc1
Copy link
Collaborator

orenc1 commented Aug 11, 2020

maybe also remove NMO from the list of components HCO is deploying & controlling, in the main readme file?
https://github.com/kubevirt/hyperconverged-cluster-operator/blame/master/README.md#L12

@tiraboschi
consider NMO as an external operator
cdd1940 
We are going to consume NMO as an external operator
just as a dependency at OLM level.

On CI test lanes based on OLM we are adding an additional
catalog source pointing to an index image, identified by
a floating tag, that contains only latest NMO.

Signed-off-by: Simone Tiraboschi <[email protected]>
@tiraboschi
Copy link
Member Author

maybe also remove NMO from the list of components HCO is deploying & controlling, in the main readme file?
https://github.com/kubevirt/hyperconverged-cluster-operator/blame/master/README.md#L12

I'm moving it to a new section called dependencies.

@ovirt-infra
Copy link

All tests passed

orenc1
orenc1 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@orenc1 orenc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
nunnatsa
nunnatsa approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@kubevirt-bot kubevirt-bot merged commit c667368 into kubevirt:master Aug 11, 2020
@tiraboschi tiraboschi deleted the ext_nmo branch August 27, 2020 16:39
@tiraboschi
Copy link
Member Author

/revert

kubevirt-bot pushed a commit that referenced this pull request Sep 3, 2020
@tiraboschi
Revert "consider NMO as an external operator (#737)" (#771)
0f7d507 
This reverts commit c667368.

Signed-off-by: Simone Tiraboschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@orenc1 orenc1 orenc1 approved these changes

@slintes slintes Awaiting requested review from slintes

@djzager djzager Awaiting requested review from djzager

Assignees

@orenc1 orenc1

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tiraboschi @ovirt-infra @slintes @kubevirt-bot @nunnatsa @orenc1