Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csv-merger: support passing environment variables #738

Merged
merged 1 commit into from
Aug 11, 2020
Merged

csv-merger: support passing environment variables #738

merged 1 commit into from
Aug 11, 2020

Conversation

yuvalturg
Copy link
Contributor

@yuvalturg yuvalturg commented Aug 10, 2020 •
edited by tiraboschi
Loading

When generating the CSV, we would like to have the option to pass in
extra environment variables for the HCO deployment.
This patch introduces the --env-vars flag that accepts a comma separated
list of key=value pairs.

Signed-off-by: Yuval Turgeman [email protected]

Release note:

csv-merger: support passing environment variables

csv-merger: support passing environment variables
a28e2fd 
When generating the CSV, we would like to have the option to pass in
extra environment variables for the HCO deployment.
This patch introduces the --env-vars flag that accepts a comma separated
list of key=value pairs.

Signed-off-by: Yuval Turgeman <[email protected]>
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2020
@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-azure
/test hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-azure
/test hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/test hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuvalturg
Copy link
Contributor Author

/retest

@kubevirt-bot kubevirt-bot merged commit 2573dc0 into kubevirt:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@djzager djzager Awaiting requested review from djzager

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuvalturg @ovirt-infra @tiraboschi @kubevirt-bot