Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Snapshot feature gate on the Kubevirt ConfigMap #805

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Enable Snapshot feature gate on the Kubevirt ConfigMap #805

merged 1 commit into from
Sep 17, 2020

Conversation

tiraboschi
Copy link
Member

Start reconciling also virtconfig.FeatureGatesKey
(currently only on HCO upgrade) to set the new
value also on deployment started in the past.
In the next version we are going to continuously
reconciling the whole ConfigMap.

Fixes: Bug-Url: https://bugzilla.redhat.com/1878060

Signed-off-by: Simone Tiraboschi [email protected]

Release note:

Enable Snapshot feature gate on the Kubevirt ConfigMap

@tiraboschi
Enable Snapshot feature gate on the Kubevirt ConfigMap
fb3789f 
Start reconciling also virtconfig.FeatureGatesKey
(currently only on HCO upgrade) to set the new
value also on deployment started in the past.
In the next version we are going to continuously
reconciling the whole ConfigMap.

Fixes: Bug-Url: https://bugzilla.redhat.com/1878060

Signed-off-by: Simone Tiraboschi <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Sep 16, 2020
@ovirt-infra
Copy link

All tests passed

@tiraboschi
Copy link
Member Author

/test hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

/test hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@tiraboschi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-image-index-gcp fb3789f link /test hco-e2e-image-index-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nunnatsa
nunnatsa approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@nunnatsa
Copy link
Collaborator

/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-image-index-gcp

In response to this:

/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@kubevirt-bot kubevirt-bot merged commit cb4833a into kubevirt:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

@djzager djzager Awaiting requested review from djzager

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiraboschi @ovirt-infra @kubevirt-bot @openshift-ci-robot @nunnatsa