Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error while checking if running in openshift #808

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fix error while checking if running in openshift #808

merged 1 commit into from
Sep 17, 2020

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Sep 17, 2020 •
edited
Loading

Fix #806 - Use KV implementation directly instead of copying it.

Signed-off-by: Nahshon Unna-Tsameret [email protected]

Release note:

NONE

@nunnatsa
Fix error while checking if running in openshift
d382928 
Use KV implementation directly instead of copying it.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 17, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Sep 17, 2020
@nunnatsa nunnatsa requested review from orenc1, yuvalturg and tiraboschi and removed request for djzager and rwsu September 17, 2020 06:15
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@nunnatsa
Copy link
Collaborator Author

/test hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@nunnatsa: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Use /test all to run all jobs.

In response to this:

/test hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@nunnatsa: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-image-index-gcp d382928 link /test hco-e2e-image-index-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiraboschi
Copy link
Member

hco-e2e-upgrade-prev-aws passed
/override ci/prow/hco-e2e-upgrade-prev-azure
hco-e2e-aws and hco-e2e-azure passed, hco-e2e-image-index-gcp fails only due to infra issues.
/override hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@tiraboschi: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • hco-e2e-image-index-gcp

Only the following contexts were expected:

  • ci/prow/ci-index
  • ci/prow/hco-e2e-aws
  • ci/prow/hco-e2e-azure
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-upgrade-aws
  • ci/prow/hco-e2e-upgrade-azure
  • ci/prow/hco-e2e-upgrade-prev-aws
  • ci/prow/hco-e2e-upgrade-prev-azure
  • ci/prow/images
  • continuous-integration/travis-ci/pr
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.17
  • tide

In response to this:

hco-e2e-upgrade-prev-aws passed
/override ci/prow/hco-e2e-upgrade-prev-azure
hco-e2e-aws and hco-e2e-azure passed, hco-e2e-image-index-gcp fails only due to infra issues.
/override hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-image-index-gcp

In response to this:

/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 51f0294 into kubevirt:master Sep 17, 2020
@nunnatsa nunnatsa deleted the fix-cluster-type-detc branch September 17, 2020 07:55
orenc1 pushed a commit to orenc1/hyperconverged-cluster-operator that referenced this pull request Sep 17, 2020
@nunnatsa @orenc1
Fix error while checking if running in openshift (kubevirt#808)
50bdb05 
Use KV implementation directly instead of copying it.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CheckRunningInOpenshift fails on OCP/OKD 4.6
5 participants
@nunnatsa @ovirt-infra @tiraboschi @kubevirt-bot @openshift-ci-robot