Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump VM_IMPORT to v0.2.2 #814

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Bump VM_IMPORT to v0.2.2 #814

merged 1 commit into from
Sep 22, 2020

Conversation

pkliczewski
Copy link
Contributor

@pkliczewski pkliczewski commented Sep 21, 2020 •
edited by tiraboschi
Loading

Bump VM_IMPORT to v0.2.2

Release note:

Bump VM_IMPORT to v0.2.2

Signed-off-by: Piotr Kliczewski [email protected]

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XXL labels Sep 21, 2020
@kubevirt-bot kubevirt-bot requested review from orenc1 and rwsu September 21, 2020 10:39
@pkliczewski
Copy link
Contributor Author

@tiraboschi @nunnatsa This version contains import from vmware which got exception to be merged into 2.5 branch.

@pkliczewski
Copy link
Contributor Author

@fdupont-redhat FYI

@ovirt-infra
Copy link

All tests passed

nunnatsa
nunnatsa requested changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run make build-manifest to re-generate the manifest files correctly.

@orenc1
Copy link
Collaborator

orenc1 commented Sep 21, 2020

please run make build-manifest to re-generate the manifest files correctly.

and update go.mod with the updated version for github.com/kubevirt/vm-import-operator, then run:

go mod vendor
go mod tidy

@pkliczewski
Copy link
Contributor Author

please run make build-manifest to re-generate the manifest files correctly.

This is exactly what I did. I wonder why the script end like this. I haven't check what was generated. It seems like I need to stop to trust those tools.

@ovirt-infra
Copy link

All tests passed

orenc1
orenc1 requested changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@orenc1 orenc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update go.mod with the updated version for github.com/kubevirt/vm-import-operator
https://github.com/kubevirt/hyperconverged-cluster-operator/blob/master/go.mod#L15
then run:

go mod vendor
go mod tidy

@pkliczewski
Copy link
Contributor Author

/retest

@pkliczewski
Copy link
Contributor Author

I opened #817 to track build-manifest issue.

@ovirt-infra
Copy link

All tests passed

@pkliczewski
Copy link
Contributor Author

please update go.mod with the updated version for github.com/kubevirt/vm-import-operator
https://github.com/kubevirt/hyperconverged-cluster-operator/blob/master/go.mod#L15
then run:

@orenc1 No changes to go.mod. what do you expect to see there?

@hco-bot
Copy link
Collaborator

hco-bot commented Sep 21, 2020

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-awshco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/hco-e2e-awshco-e2e-upgrade-aws lane succeeded.

Only the following contexts were expected:

  • ci/prow/ci-index
  • ci/prow/hco-e2e-aws
  • ci/prow/hco-e2e-azure
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-azure
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-upgrade-aws
  • ci/prow/hco-e2e-upgrade-azure
  • ci/prow/hco-e2e-upgrade-prev-aws
  • ci/prow/hco-e2e-upgrade-prev-azure
  • ci/prow/images
  • continuous-integration/travis-ci/pr
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.17
  • tide

In response to this:

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-awshco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-aws, ci/prow/hco-e2e-upgrade-azure

In response to this:

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws
hco-e2e-upgrade-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

hco-e2e-image-index-aws and hco-e2e-image-index-gcp passed CI
/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws and hco-e2e-image-index-gcp passed CI
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

please update go.mod with the updated version for github.com/kubevirt/vm-import-operator
https://github.com/kubevirt/hyperconverged-cluster-operator/blob/master/go.mod#L15
then run:

@orenc1 No changes to go.mod. what do you expect to see there?

v0.2.1 -> v0.2.2 on https://github.com/kubevirt/hyperconverged-cluster-operator/blob/master/go.mod#L15

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020
@pkliczewski
Copy link
Contributor Author

v0.2.1 -> v0.2.2 on https://github.com/kubevirt/hyperconverged-cluster-operator/blob/master/go.mod#L15

@tiraboschi Done. It is interesting that I did it for the first time. Have I missed it in the past or is it something new?

@ovirt-infra
Copy link

All tests passed

@hco-bot
Copy link
Collaborator

hco-bot commented Sep 21, 2020

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azurehco-e2e-aws lane succeeded.
/override ci/prow/hco-e2e-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/hco-e2e-image-index-azurehco-e2e-aws lane succeeded.

Only the following contexts were expected:

  • ci/prow/ci-index
  • ci/prow/hco-e2e-aws
  • ci/prow/hco-e2e-azure
  • ci/prow/hco-e2e-image-index-aws
  • ci/prow/hco-e2e-image-index-azure
  • ci/prow/hco-e2e-image-index-gcp
  • ci/prow/hco-e2e-upgrade-aws
  • ci/prow/hco-e2e-upgrade-azure
  • ci/prow/hco-e2e-upgrade-prev-aws
  • ci/prow/hco-e2e-upgrade-prev-azure
  • ci/prow/images
  • continuous-integration/travis-ci/pr
  • pull-hyperconverged-cluster-operator-e2e-k8s-1.17
  • tide

In response to this:

hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded.
/override ci/prow/hco-e2e-image-index-azurehco-e2e-aws lane succeeded.
/override ci/prow/hco-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pkliczewski
Copy link
Contributor Author

/retest

1 similar comment
@pkliczewski
Copy link
Contributor Author

/retest

@pkliczewski
Copy link
Contributor Author

@tiraboschi I still see the same job failure issue as before the rebase:

error: error executing jsonpath "{range .status.conditions[*]}{.type}{'\t'}{.status}{'\t'}{.message}{'\n'}{end}": Error executing template: not in range, nothing to end.

Is this still expected?

@orenc1
Copy link
Collaborator

orenc1 commented Sep 22, 2020

/rebase

@orenc1
Copy link
Collaborator

orenc1 commented Sep 22, 2020

@pkliczewski , please rebase to consume the CI upgrade test unlock that was merged in #820
your PR can't be rebased by us, since you used a master branch.

Thanks

@pkliczewski
Bump VM_IMPORT to v0.2.2
50b0210 
Signed-off-by: Piotr Kliczewski <[email protected]>
@ovirt-infra
Copy link

All tests passed

@nunnatsa
Copy link
Collaborator

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2020
nunnatsa
nunnatsa approved these changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@kubevirt-bot kubevirt-bot merged commit 8dab804 into kubevirt:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenc1 orenc1 orenc1 requested changes

@nunnatsa nunnatsa nunnatsa approved these changes

@rwsu rwsu Awaiting requested review from rwsu

Assignees

@orenc1 orenc1

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pkliczewski @ovirt-infra @orenc1 @hco-bot @kubevirt-bot @tiraboschi @nunnatsa