[Release 1.2] Fix CSV merge issues #831
Conversation
Adda a flag to the csv-merger tool to optionally ignore relatedImages from component operators generated CSV. Signed-off-by: Simone Tiraboschi <[email protected]>
* add error handling to hack/build-manifest.sh
`set -e` does not stop the process if the error is happened within a command substitution. This is why the [`hack/build-manifest.sh`] script didn't fail in some cases, e.g. when an image was missing in the remote registry.
This PR added error handling to the script:
* Added `trap` command and the `catch` method
* command substitution inside string building didn't catch by the trap. This lines were split to make sure the trap catches any error. For example:
```bash
A_VARIABLE="Text text${VAR1}/$(failed command)"
```
was split to something like:
```bash
A_TEMP_VAR="$(failed command)"
A_VARIABLE="Text text${VAR1}/${A_TEMP_VAR}"
```
* Single line local variables with command substitution were not caught by the trap, and was also split. For example:
```bash
function foo() {
...
local a_variable="$(failed command)"
...
```
was split to something like:
```bash
function foo() {
...
local a_variable
a_variable="$(failed command)"
...
```
* Add simple versifcation to the operator CSV files, by greping for their `image:` line. This check both that the file is not empty and the image makes some sense
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
* csv-merger will now panic if one of the CSVs is empty
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
kubevirt-bot
added
the
release-note
|
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
kubevirt-bot
added
the
dco-signoff: yes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/override ci/prow/hco-e2e-azure |
|
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherry pick #828 and #829
#fixes https://bugzilla.redhat.com/1882052
Release note: