Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] Partially reconcile IMS ConfigMap #856

Merged
merged 1 commit into from
Oct 2, 2020
Merged

[release-1.2] Partially reconcile IMS ConfigMap #856

merged 1 commit into from
Oct 2, 2020

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #854

/assign tiraboschi

Partially reconcile IMS ConfigMap

@tiraboschi
Partially reconcile IMS ConfigMap
9d65f74 
v2v-vmware is created and managed by HCO operator;
with kubevirt#832 we started properly reconciling it.
Unfortunately, due to a bad design, v2v-vmware is
also abused by other components that injects other
values there.
A proper design consist in splitting it into two distinct
config-maps. As a quick but dirty fix let's start
reconciling only a few values from HCO.

Fixes: https://bugzilla.redhat.com/1884538

Signed-off-by: Simone Tiraboschi <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Oct 2, 2020
Merged
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 2, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Oct 2, 2020
@kubevirt-bot kubevirt-bot requested review from orenc1 and sradco October 2, 2020 13:35
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@tiraboschi
Copy link
Member

hco-e2e-upgrade-prev-aws passed, no need to wait for hco-e2e-upgrade-prev-azure
/override ci/prow/hco-e2e-upgrade-prev-azure

@kubevirt-bot
Copy link
Contributor Author

@tiraboschi: Overrode contexts on behalf of tiraboschi: ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-upgrade-prev-aws passed, no need to wait for hco-e2e-upgrade-prev-azure
/override ci/prow/hco-e2e-upgrade-prev-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020
@kubevirt-bot kubevirt-bot merged commit b60940f into kubevirt:release-1.2 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

@sradco sradco Awaiting requested review from sradco

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubevirt-bot @ovirt-infra @tiraboschi