-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.2] Add Operator Descriptors to properly render node placement on UI (#864) #868
Conversation
…evirt#864) Following https://github.com/openshift/console/tree/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors , let's add Operator Descriptors to get node placement APIs pretty rendered on UI form. Kubebuilder still doens't directly supports them with its annotations as the oeprator-sdk does, so let's add them to the CRD Templates stanza in the ClusterServiceVersion. Use the same mechanism to hide spec.version from the create form. Fixes: https://bugzilla.redhat.com/1885535 Signed-off-by: Simone Tiraboschi <[email protected]> Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hco-e2e-image-index-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nunnatsa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
hco-e2e-image-index-gcp lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Following
https://github.com/openshift/console/tree/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors ,
let's add Operator Descriptors to get node placement APIs
pretty rendered on UI form.
Kubebuilder still doens't directly supports them with its
annotations as the oeprator-sdk does, so let's add them
to the CRD Templates stanza in the ClusterServiceVersion.
Use the same mechanism to hide spec.version from the create
form.
Fixes: https://bugzilla.redhat.com/1885535
Signed-off-by: Simone Tiraboschi [email protected]
Signed-off-by: Nahshon Unna-Tsameret [email protected]
Release note: