Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] Add Operator Descriptors to properly render node placement on UI (#864) #868

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Oct 7, 2020

Following
https://github.com/openshift/console/tree/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors ,
let's add Operator Descriptors to get node placement APIs
pretty rendered on UI form.

Kubebuilder still doens't directly supports them with its
annotations as the oeprator-sdk does, so let's add them
to the CRD Templates stanza in the ClusterServiceVersion.

Use the same mechanism to hide spec.version from the create
form.

Fixes: https://bugzilla.redhat.com/1885535

Signed-off-by: Simone Tiraboschi [email protected]
Signed-off-by: Nahshon Unna-Tsameret [email protected]

Release note:

Add Operator Descriptors to properly render node placement on UI

…evirt#864)

Following
https://github.com/openshift/console/tree/master/frontend/packages/operator-lifecycle-manager/src/components/descriptors ,
let's add Operator Descriptors to get node placement APIs
pretty rendered on UI form.

Kubebuilder still doens't directly supports them with its
annotations as the oeprator-sdk does, so let's add them
to the CRD Templates stanza in the ClusterServiceVersion.

Use the same mechanism to hide spec.version from the create
form.

Fixes: https://bugzilla.redhat.com/1885535

Signed-off-by: Simone Tiraboschi <[email protected]>
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 7, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Oct 7, 2020
@nunnatsa nunnatsa changed the title Add Operator Descriptors to properly render node placement on UI (#864) [release-1.2] Add Operator Descriptors to properly render node placement on UI (#864) Oct 7, 2020
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@hco-bot
Copy link
Collaborator

hco-bot commented Oct 7, 2020

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@nunnatsa: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-image-index-aws 8058aa2 link /test hco-e2e-image-index-aws
ci/prow/hco-e2e-image-index-azure 8058aa2 link /test hco-e2e-image-index-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 7, 2020

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 70fb211 into kubevirt:release-1.2 Oct 7, 2020
@nunnatsa nunnatsa deleted the release-1.2 branch October 7, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants