Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the reconciliation of components CRs #871

Merged
merged 1 commit into from
Oct 11, 2020
Merged

Fix the reconciliation of components CRs #871

merged 1 commit into from
Oct 11, 2020

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented Oct 8, 2020 •
edited
Loading

Fix the reconciliation of components CRs

Correctly copy spec stanza on components CR
with deepCopy to recursively handle also complex
types.

Fix unit tests:
Ω(ACTUAL).Should(Equal(EXPECTED))
uses reflect.DeepEqual to compare ACTUAL with EXPECTED.

VMImportConfig is global scoped!!!

Fixes: https://bugzilla.redhat.com/1884142

Signed-off-by: Simone Tiraboschi [email protected]

Release note:

Fix the reconciliation of components CRs

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 8, 2020
@kubevirt-bot kubevirt-bot requested a review from sradco October 8, 2020 15:43
@ovirt-infra
Copy link

All tests passed

3 similar comments
@ovirt-infra
Copy link

All tests passed

@ovirt-infra
Copy link

All tests passed

@ovirt-infra
Copy link

All tests passed

@tiraboschi
Copy link
Member Author

/retest

@ovirt-infra
Copy link

All tests passed

@kubevirt-bot kubevirt-bot added size/L and removed size/M labels Oct 9, 2020
@ovirt-infra
Copy link

All tests passed

@tiraboschi
Fix the reconciliation of components CRs
ea9b114 
Correctly copy spec stanza on components CR
with deepCopy to recursively handle also complex
types.

Fix unit tests:
Ω(ACTUAL).Should(Equal(EXPECTED))
uses reflect.DeepEqual to compare ACTUAL with EXPECTED.

VMImportConfig is global scoped!!!

Fixes: https://bugzilla.redhat.com/1884142

Signed-off-by: Simone Tiraboschi <[email protected]>
@ovirt-infra
Copy link

All tests passed

@tiraboschi
Copy link
Member Author

Ignore slightly decreased coverage
/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls

In response to this:

Ignore slightly decreased coverage
/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@tiraboschi tiraboschi requested a review from orenc1 October 9, 2020 14:31
nunnatsa
nunnatsa approved these changes Oct 11, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2020
@kubevirt-bot kubevirt-bot merged commit 4fef62a into kubevirt:master Oct 11, 2020
@tiraboschi tiraboschi deleted the fix_cr_reconciliation branch October 11, 2020 08:42
@tiraboschi
Copy link
Member Author

/cherry-pick release-1.2

@kubevirt-bot kubevirt-bot mentioned this pull request Oct 11, 2020
Merged
@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #876

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi tiraboschi added the hacktoberfest-accepted PRs accepted for hacktoberfest2020 label Oct 27, 2020
@kubevirt-bot
Copy link
Contributor

@tiraboschi: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/kubevirt-bot/hyperconverged-cluster-operator\n ! [rejected] cherry-pick-871-to-release-1.2 -> cherry-pick-871-to-release-1.2 (non-fast-forward)\nerror: failed to push some refs to 'https://kubevirt-bot:[email protected]/kubevirt-bot/hyperconverged-cluster-operator'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@pkliczewski pkliczewski pkliczewski approved these changes

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

@sradco sradco Awaiting requested review from sradco

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@pkliczewski pkliczewski

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. hacktoberfest-accepted PRs accepted for hacktoberfest2020 lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiraboschi @ovirt-infra @kubevirt-bot @pkliczewski @nunnatsa