Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CSV Annotation for HCO CR deployment during installation #881

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Adding CSV Annotation for HCO CR deployment during installation #881

merged 1 commit into from
Oct 14, 2020

Conversation

orenc1
Copy link
Collaborator

@orenc1 orenc1 commented Oct 13, 2020

Utilizing OLM feature of creating the operand's CR as a part of the installation process through OpertorHub.

Signed-off-by: orenc1 [email protected]

Release note:

add initialization-resource annotation to CSV

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 13, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2020
@orenc1 orenc1 force-pushed the initialization-resource-annotation branch from 55b3682 to fae3fdb Compare October 13, 2020 17:10
@kubevirt-bot kubevirt-bot added size/S and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M labels Oct 13, 2020
@orenc1 orenc1 force-pushed the initialization-resource-annotation branch 2 times, most recently from 30d6891 to 20e77b0 Compare October 13, 2020 17:19
@nunnatsa
Copy link
Collaborator

/rebase

@orenc1 orenc1 force-pushed the initialization-resource-annotation branch 4 times, most recently from cd3cc42 to c389741 Compare October 14, 2020 13:09
@orenc1
Adding CSV Annotation for initialization resource. Utilizing OLM feat…
51a4325 
…ure of creating the operand's CR as a part of the installation process using OpertorHub.

Signed-off-by: orenc1 <[email protected]>
@orenc1 orenc1 force-pushed the initialization-resource-annotation branch from c389741 to 51a4325 Compare October 14, 2020 13:46
@nunnatsa
Copy link
Collaborator

/override pull-hco-node-placement-k8s-1.17

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: pull-hco-node-placement-k8s-1.17

In response to this:

/override pull-hco-node-placement-k8s-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa
nunnatsa approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@kubevirt-bot kubevirt-bot merged commit d8d5c8a into kubevirt:master Oct 14, 2020
@orenc1 orenc1 deleted the initialization-resource-annotation branch March 15, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@orenc1 @ovirt-infra @nunnatsa @kubevirt-bot