Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move KV and CDI to the new operand pkg #903

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

nunnatsa
Copy link
Collaborator

@nunnatsa nunnatsa commented Oct 28, 2020

Signed-off-by: Nahshon Unna-Tsameret [email protected]

This is the 2nd (2/10) commit of the reconcile refactoring.

It introduces the Operand interface, and uses it to handle KubeVirt and CDI CRs.

The current ensure methods of KV and CDI are left, but their content was move to the new operand package.

The reconciler holds a temporary map of handlers, currently only with KV and CDI handlers. This will be removed later.

Some code in the PR is an intrastructure for all the operands, so it's larger than the following PRs, that will only deal with a single operand.

The new commonTestUtis package also added, to serve unit test both in the hyperconvereged and the operands packages.

Release note:

NONE

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 28, 2020
@nunnatsa nunnatsa requested a review from tiraboschi October 28, 2020 09:19
@nunnatsa
Copy link
Collaborator Author

This is the first commit out of 10. The final covarage was +3.5%

/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

This is the first commit out of 10. The final covarage was +3.5%

/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa
Copy link
Collaborator Author

/hold

waiting for #823

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
@nunnatsa
Copy link
Collaborator Author

rebased with #823.

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2020
@nunnatsa
Copy link
Collaborator Author

This is the second commit out of 10. The final covarage was +3.5%

/override coverage/coveralls

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls

In response to this:

This is the second commit out of 10. The final covarage was +3.5%

/override coverage/coveralls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2020
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@kubevirt-bot kubevirt-bot merged commit 52b82f9 into kubevirt:master Oct 28, 2020
@nunnatsa nunnatsa deleted the operands-picks branch October 28, 2020 13:10
@nunnatsa nunnatsa mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants