-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move KV and CDI to the new operand pkg #903
Conversation
This is the first commit out of 10. The final covarage was +3.5% /override coverage/coveralls |
@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold waiting for #823 |
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
56f7ea8
to
1c1c31a
Compare
rebased with #823. /unhold |
This is the second commit out of 10. The final covarage was +3.5% /override coverage/coveralls |
@nunnatsa: Overrode contexts on behalf of nunnatsa: coverage/coveralls In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Nahshon Unna-Tsameret [email protected]
This is the 2nd (2/10) commit of the reconcile refactoring.
It introduces the
Operand
interface, and uses it to handle KubeVirt and CDI CRs.The current
ensure
methods of KV and CDI are left, but their content was move to the newoperand
package.The reconciler holds a temporary map of handlers, currently only with KV and CDI handlers. This will be removed later.
Some code in the PR is an intrastructure for all the operands, so it's larger than the following PRs, that will only deal with a single operand.
The new
commonTestUtis
package also added, to serve unit test both in thehyperconvereged
and theoperands
packages.Release note: