Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] Validate updates to the whole .spec stanza #913

Merged
merged 1 commit into from
Nov 16, 2020
Merged

[release-1.2] Validate updates to the whole .spec stanza #913

merged 1 commit into from
Nov 16, 2020

Conversation

kubevirt-bot
Copy link
Contributor

This is an automated cherry-pick of #912

/assign tiraboschi

Validate updates to the whole .spec stanza

@tiraboschi
Validate updates to the whole .spec stanza
6ef8806 
HCO is supposed to validate updates to its CR
also delegating to components operators the validation
of the changes it has to propagate (trying to apply
them in dry run mode first and committing only if all the
involved components accepted it).

This was done only for the .spec.worloads stanza,
applying the same strategy to the whole .spec stanza.

Fixes: https://bugzilla.redhat.com/1893646

Signed-off-by: Simone Tiraboschi <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Nov 2, 2020
Merged
@kubevirt-bot kubevirt-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 2, 2020
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Manage kubevirt CR from sdk generated code #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 2, 2020
@tiraboschi
Copy link
Member

/hold

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M labels Nov 2, 2020
@nunnatsa
Copy link
Collaborator

nunnatsa commented Nov 2, 2020

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@tiraboschi
Copy link
Member

https://bugzilla.redhat.com/1893646 is target to 2.5.1, let's wait a bit before merging this

@tiraboschi
Copy link
Member

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@kubevirt-bot kubevirt-bot merged commit 66b7b00 into kubevirt:release-1.2 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@tiraboschi tiraboschi

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubevirt-bot @ovirt-infra @tiraboschi @nunnatsa