Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] Hide nodePlacement APIs from the UI #929

Merged
merged 1 commit into from
Nov 9, 2020
Merged

[release-1.2] Hide nodePlacement APIs from the UI #929

merged 1 commit into from
Nov 9, 2020

Conversation

tiraboschi
Copy link
Member

@tiraboschi tiraboschi commented Nov 9, 2020 •
edited
Loading

[release-1.2] Hide nodePlacement APIs from the UI

Release note:

Hide nodePlacement APIs from the UI

@tiraboschi
Hide nodePlacement APIs from the UI
e54d2b6 
Signed-off-by: Simone Tiraboschi <[email protected]>
@tiraboschi tiraboschi requested review from orenc1 and nunnatsa November 9, 2020 13:27
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 9, 2020
@tiraboschi tiraboschi changed the title Hide nodePlacement APIs from the UI [release-1.2] Hide nodePlacement APIs from the UI Nov 9, 2020
@ovirt-infra
Copy link

All tests passed

nunnatsa
nunnatsa approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@kubevirt-bot kubevirt-bot merged commit 7aa0da0 into kubevirt:release-1.2 Nov 9, 2020
@tiraboschi tiraboschi deleted the release-1.2-hide_np branch November 9, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunnatsa nunnatsa nunnatsa approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

Assignees

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiraboschi @ovirt-infra @kubevirt-bot @nunnatsa