Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: try to delete the CR as a side-effect of namespace deletion #961

Closed
wants to merge 1 commit into from
Closed

wip: try to delete the CR as a side-effect of namespace deletion #961

wants to merge 1 commit into from

Conversation

tiraboschi
Copy link
Member

Signed-off-by: Simone Tiraboschi [email protected]

Release note:

@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2020
@kubevirt-bot
Copy link
Contributor

@tiraboschi: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 24, 2020
@tiraboschi tiraboschi added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2020
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tiraboschi
You can assign the PR to them by writing /assign @tiraboschi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hco-bot
Copy link
Collaborator

hco-bot commented Nov 24, 2020

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-aws

In response to this:

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Nov 26, 2020

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-aws

In response to this:

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Nov 27, 2020

hco-e2e-aws lane succeeded.
/override ci/prow/hco-e2e-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-azure

In response to this:

hco-e2e-aws lane succeeded.
/override ci/prow/hco-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added size/XXL needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L and removed size/L needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Nov 27, 2020
@hco-bot
Copy link
Collaborator

hco-bot commented Dec 1, 2020

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-aws

In response to this:

hco-e2e-azure lane succeeded.
/override ci/prow/hco-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Dec 3, 2020

hco-e2e-aws lane succeeded.
/override ci/prow/hco-e2e-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-azure

In response to this:

hco-e2e-aws lane succeeded.
/override ci/prow/hco-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Collaborator

@tiraboschi: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-image-index-aws be258c1 link /test hco-e2e-image-index-aws
ci/prow/hco-e2e-image-index-gcp be258c1 link /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-azure be258c1 link /test hco-e2e-image-index-azure
ci/prow/hco-e2e-upgrade-aws be258c1 link /test hco-e2e-upgrade-aws
ci/prow/hco-e2e-upgrade-azure be258c1 link /test hco-e2e-upgrade-azure
ci/prow/hco-e2e-upgrade-prev-azure be258c1 link /test hco-e2e-upgrade-prev-azure
ci/prow/hco-e2e-upgrade-prev-aws be258c1 link /test hco-e2e-upgrade-prev-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2020
@kubevirt-bot
Copy link
Contributor

@tiraboschi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member Author

The fix for https://bugzilla.redhat.com/1881874 is probably enough, abandoning this

@tiraboschi tiraboschi closed this Jan 8, 2021
@tiraboschi tiraboschi deleted the delete_on_ns branch January 8, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvalturg yuvalturg Awaiting requested review from yuvalturg

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

@orenc1 orenc1 Awaiting requested review from orenc1

@sradco sradco Awaiting requested review from sradco

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiraboschi @kubevirt-bot @hco-bot @openshift-merge-robot