Switch to use the new SSP operator #966

zcahana · 2020-11-26T07:40:53Z

This PR updates HCO operator to use the new Golang-based SSP operator, instead of the old Ansible-based SSP operator.

~~Note 1: This isn't mergeable yet, since the new SSP operator doesn't have a released image yet.~~
~~Note 2: I plan to add additional unit tests to cover the upgrade logic (removal of old CRDs, etc).~~

Switch to use the new SSP operator.

zcahana · 2020-11-26T07:51:31Z

pkg/controller/operands/ssp.go

@@ -3,289 +3,125 @@ package operands
 import (


Github's diff view of this file is terrible.
In essence, this file has been rewritten from scratch, so it better be viewed as a whole file, and compared to the old file as a whole.

tiraboschi · 2020-11-26T10:39:46Z

cmd/hyperconverged-cluster-operator/main.go

@@ -32,6 +31,7 @@ import (
 	apiruntime "k8s.io/apimachinery/pkg/runtime"
 	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
 	cdiv1beta1 "kubevirt.io/containerized-data-importer/pkg/apis/core/v1beta1"
+	sspv1alpha1 "kubevirt.io/ssp-operator/api/v1alpha1"


I fear we can accept it only if >= v1beta1

What is the criteria to move from v1alpha1 to v1beta1? Or this is merely a syntactical requirement?

The criteria is:

Since it is a "beta" suffixed, it should work with subsequent releases. Indeed, the meaning of api versions is as following:

alpha
API versions with ‘alpha’ in their name are early candidates for new functionality coming into Kubernetes. These may contain bugs and are not guaranteed to work in the future.

beta
‘beta’ in the API version name means that testing has progressed past alpha level, and that the feature will eventually be included in Kubernetes. Although the way it works might change, and the way objects are defined may change completely, the feature itself is highly likely to make it into Kubernetes in some form.

stable
These do not contain ‘alpha’ or ‘beta’ in their name. They are safe to use.

an operator is required to have it's CRD at least to v1beta1 to be considered GA as our previous version was.

The API version of ssp-operator is now v1beta1.

@akrejcir thanks, will update this PR to consume v1beta1.

nunnatsa

Starting the review. Currently - two comments.

pkg/controller/operands/ssp.go

zcahana · 2020-11-30T16:31:52Z

Rebased + several updates.

zcahana · 2020-12-10T11:23:48Z

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

openshift-ci-robot · 2020-12-10T11:23:51Z

@zcahana: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test ci-index
/test hco-e2e-aws
/test hco-e2e-azure
/test hco-e2e-image-index-aws
/test hco-e2e-image-index-azure
/test hco-e2e-image-index-gcp
/test hco-e2e-upgrade-aws
/test hco-e2e-upgrade-azure
/test hco-e2e-upgrade-prev-aws
/test hco-e2e-upgrade-prev-azure
/test images

Use /test all to run all jobs.

In response to this:

/test pull-hyperconverged-cluster-operator-e2e-k8s-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2020-12-10T11:26:28Z

/retest

Signed-off-by: Zvi Cahana <[email protected]>

nunnatsa

/approve

openshift-ci · 2021-01-07T16:08:20Z

@zcahana: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/hco-e2e-image-index-gcp	bb7e141a62ade0f7ce30399b1b7fc9efca742f73	link	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-upgrade-aws	`414c3a1`	link	`/test hco-e2e-upgrade-aws`
ci/prow/hco-e2e-upgrade-azure	`414c3a1`	link	`/test hco-e2e-upgrade-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

nunnatsa · 2021-01-07T16:10:16Z

/override ci/prow/hco-e2e-upgrade-aws
/override ci/prow/hco-e2e-upgrade-azure

Failure is expected

/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure hco-e2e-image-index-aws passed

kubevirt-bot · 2021-01-07T16:10:23Z

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-aws, ci/prow/hco-e2e-upgrade-azure

In response to this:

/override ci/prow/hco-e2e-upgrade-aws
/override ci/prow/hco-e2e-upgrade-azure

Failure is expected

/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-image-index-azure hco-e2e-image-index-aws passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa

/approve

tiraboschi · 2021-01-07T16:11:51Z

/unhold

kubevirt-bot · 2021-01-07T16:12:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot requested review from andreyod and nunnatsa November 26, 2020 07:41

kubevirt-bot added the size/XXL label Nov 26, 2020

zcahana commented Nov 26, 2020

View reviewed changes

tiraboschi reviewed Nov 26, 2020

View reviewed changes

nunnatsa reviewed Nov 26, 2020

View reviewed changes

pkg/controller/operands/ssp.go Outdated Show resolved Hide resolved

pkg/controller/operands/ssp.go Outdated Show resolved Hide resolved

zcahana force-pushed the new_ssp branch from 63bd847 to 520072c Compare November 30, 2020 16:31

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2020

zcahana force-pushed the new_ssp branch from 520072c to 6336364 Compare December 6, 2020 11:44

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 6, 2020

zcahana force-pushed the new_ssp branch 2 times, most recently from 9f12f63 to b581156 Compare December 7, 2020 10:16

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2020

zcahana force-pushed the new_ssp branch from b581156 to 96a5877 Compare December 9, 2020 11:48

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2020

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2020

zcahana force-pushed the new_ssp branch from a8851a0 to 873389e Compare December 13, 2020 14:05

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2020

zcahana force-pushed the new_ssp branch 4 times, most recently from 75cccb4 to 4a7d341 Compare December 14, 2020 17:18

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2020

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2021

zcahana added 14 commits January 7, 2021 15:20

Vendor kubevirt.io/ssp-operator

0ed74a7

Signed-off-by: Zvi Cahana <[email protected]>

Switch to use the new SSP operator

60b31f4

Signed-off-by: Zvi Cahana <[email protected]>

Unit tests for new SSP operator

3ebee5e

Signed-off-by: Zvi Cahana <[email protected]>

Align webhook with new SSP operator

ee124ab

Signed-off-by: Zvi Cahana <[email protected]>

Update CSV generation for new SSP

021df4f

Signed-off-by: Zvi Cahana <[email protected]>

Additional automation updates

fd1a794

Signed-off-by: Zvi Cahana <[email protected]>

Remove old SSP CRs from RelatedObjects

bffd941

Signed-off-by: Zvi Cahana <[email protected]>

Bump SSP to v0.1.0-rc.2

3dbe0c8

Signed-off-by: Zvi Cahana <[email protected]>

add an upgrade test script to validate old SSP removal

5224261

Signed-off-by: Zvi Cahana <[email protected]>

NewHyperConvergedConfig() ==> NewNodePlacement()

431bacc

Signed-off-by: Zvi Cahana <[email protected]>

/hack/retry ==> /hack/retry.sh (doh!)

c39cb0e

Signed-off-by: Zvi Cahana <[email protected]>

Increase timeout waiting for new CSV to report success

5353876

Signed-off-by: Zvi Cahana <[email protected]>

Fix CSV rebase-glitch

d2affbc

Signed-off-by: Zvi Cahana <[email protected]>

Cherry-pick 1.3.0 CSV

414c3a1

Signed-off-by: Zvi Cahana <[email protected]>

zcahana force-pushed the new_ssp branch from bb7e141 to 414c3a1 Compare January 7, 2021 14:23

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2021

nunnatsa approved these changes Jan 7, 2021

View reviewed changes

kubevirt-bot assigned nunnatsa Jan 7, 2021

kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 7, 2021

nunnatsa approved these changes Jan 7, 2021

View reviewed changes

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2021

kubevirt-bot merged commit 7fb5927 into kubevirt:master Jan 7, 2021

zcahana deleted the new_ssp branch January 7, 2021 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to use the new SSP operator #966

Switch to use the new SSP operator #966

zcahana commented Nov 26, 2020 •

edited

Loading

zcahana Nov 26, 2020

tiraboschi Nov 26, 2020

zcahana Nov 26, 2020

tiraboschi Nov 26, 2020

akrejcir Dec 4, 2020

zcahana Dec 6, 2020

nunnatsa left a comment

zcahana commented Nov 30, 2020

zcahana commented Dec 10, 2020

openshift-ci-robot commented Dec 10, 2020

tiraboschi commented Dec 10, 2020

nunnatsa left a comment

openshift-ci bot commented Jan 7, 2021

nunnatsa commented Jan 7, 2021

kubevirt-bot commented Jan 7, 2021

nunnatsa left a comment

tiraboschi commented Jan 7, 2021

kubevirt-bot commented Jan 7, 2021

Switch to use the new SSP operator #966

Switch to use the new SSP operator #966

Conversation

zcahana commented Nov 26, 2020 • edited Loading

zcahana Nov 26, 2020

Choose a reason for hiding this comment

tiraboschi Nov 26, 2020

Choose a reason for hiding this comment

zcahana Nov 26, 2020

Choose a reason for hiding this comment

tiraboschi Nov 26, 2020

Choose a reason for hiding this comment

akrejcir Dec 4, 2020

Choose a reason for hiding this comment

zcahana Dec 6, 2020

Choose a reason for hiding this comment

nunnatsa left a comment

Choose a reason for hiding this comment

zcahana commented Nov 30, 2020

zcahana commented Dec 10, 2020

openshift-ci-robot commented Dec 10, 2020

tiraboschi commented Dec 10, 2020

nunnatsa left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 7, 2021

nunnatsa commented Jan 7, 2021

kubevirt-bot commented Jan 7, 2021

nunnatsa left a comment

Choose a reason for hiding this comment

tiraboschi commented Jan 7, 2021

kubevirt-bot commented Jan 7, 2021

zcahana commented Nov 26, 2020 •

edited

Loading