Provide default values for ceph RBD. #969
Conversation
kubevirt-bot
added
release-note
There was a problem hiding this comment.
Can you please also add a unit test for this ensuring that HCO is properly covering the upgrade scenario (the ConfigMap was already there from a previous version and HCO should reconcile it adding the missing values)?
I tend to think that HCO is not going to reconcile that object.
tiraboschi
added
the
do-not-merge/hold
|
hco-e2e-image-index-aws, hco-e2e-image-index-gcp lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Not sure how to run the upgrade tests. |
I was simply asking for a unit test to ensure that HCO is really going to add the two new keys to that config map if the config map has been created in the past. The issue is that, as I was suspecting, HCO is not going to add the two new keys because HCO is currently not reconciling that object but just the CR for cdi-operator. |
|
hco-e2e-image-index-gcp, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Maya Rashish <[email protected]> Add unit test (currently failing) Signed-off-by: Simone Tiraboschi <[email protected]>
Signed-off-by: Maya Rashish <[email protected]>
Signed-off-by: Maya Rashish <[email protected]>
|
/approve |
kubevirt-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tiraboschi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Release note: