Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll-up of updates to migrate from Kata- to Killer- coda #35

Merged
merged 22 commits into from
Jul 27, 2022

Conversation

cwilkers
Copy link
Member

Updates:

  • Reword summary text of scenarios to flow better with each other
  • Update all environments to use killercoda's environments
  • Add background scripts to scenarios to set up environments
  • Add foreground scripts that wait for deployments to complete before handing over prompt
  • Add colorization of prompts to better hilight command vs output in window
  • Pare down resource requirements for scenarios beyond initial kubevirt install
  • Change target of CDI example to smaller CirrOs image to fit reduced environment
  • Update code samples with output that matches Killercoda environment

cwilkers added 3 commits July 6, 2022 16:57
- Added structure to sort and title scenarios in KC interface
- Updated to remove or change mentions of KataCoda

Signed-off-by: cwilkers <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jul 27, 2022
@kubevirt-bot kubevirt-bot requested a review from mazzystr July 27, 2022 16:04
cwilkers added 19 commits July 27, 2022 11:13
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Updating migration scenario to use fore/background scripts

Signed-off-by: cwilkers <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 27, 2022
Copy link

@jobbler jobbler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check all occurences of {{execute}}. They all render on output and some cause other parts of the page to render incorrectly

```
export KUBEVIRT_VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt/releases/latest | jq -r .tag_name)
echo $KUBEVIRT_VERSION
```{{execute}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot triple ticks somewhere. this does not render correctly.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it also causes the remaining page to not render correctly


The command below applies a YAML definition of a virtual machine into our current Kubernetes environment, defining the VM name, the resources required (disk, CPU, memory), etc. You can take a look at the [vm.yaml](https://kubevirt.io/labs/manifests/vm.yaml) file if you have interest in knowing more about a virtual machine definition:
The command below applies a YAML definition of a virtual machine into the current Kubernetes environment, defining the VM name, the resources required (disk, CPU, memory), etc. You can take a look at the [vm.yaml](https://kubevirt.io/labs/manifests/vm.yaml) file if you have interest in knowing more about a virtual machine definition:

`kubectl apply -f https://kubevirt.io/labs/manifests/vm.yaml`{{execute}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the {{execute}} tags I keep seeing. They render on output. Its not just this file I see them on.


Next, we need to configure KubeVirt to use software emulation for virtualization. This is necessary for the Katacoda environment, but results in poor performance, so avoid this step in production environments.
`kubectl get storageclass`{{execute}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, the {{execute}} renders on output

```
export VERSION=$(curl -Ls https://github.com/kubevirt/containerized-data-importer/releases/latest | grep -m 1 -o "v[0-9]\.[0-9]*\.[0-9]*")
echo $VERSION
```{{execute}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the {{execute}} may be messing with the three back tics. The remaining page does not render correctly.


Verify you now have a default storage class. You should see "kubevirt-hostpath-provisioner (default)"

`kubectl get storageclass`{{execute}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, the {{execute}} renders and the remaidner of the page renders incorrectly.


`kubectl -n kubevirt get kubevirt kubevirt -o yaml`{{execute}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this {{execute}} and the remaining {{execute}} renders.

virtctl expose vmi testvm --name=testvm-ssh --port=22 --type=NodePort
virtctl expose vmi testvm --name=testvm-http --port=8080 --type=NodePort
`{{execute}}
```{{execute}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ex3ecute renders and the remainder of the page does not render correctly.

@cwilkers
Copy link
Member Author

cwilkers commented Jul 27, 2022 via email

@jobbler
Copy link

jobbler commented Jul 27, 2022

since the tags render correctly on the platform. I would say this loogs good to me then.
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@cwilkers
Copy link
Member Author

/approve

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@kubevirt-bot kubevirt-bot merged commit 4b4f3db into kubevirt:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants