-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll-up of updates to migrate from Kata- to Killer- coda #35
Conversation
Signed-off-by: cwilkers <[email protected]>
- Added structure to sort and title scenarios in KC interface - Updated to remove or change mentions of KataCoda Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
…nodes Signed-off-by: cwilkers <[email protected]>
Signed-off-by: cwilkers <[email protected]>
Updating migration scenario to use fore/background scripts Signed-off-by: cwilkers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check all occurences of {{execute}}. They all render on output and some cause other parts of the page to render incorrectly
``` | ||
export KUBEVIRT_VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt/releases/latest | jq -r .tag_name) | ||
echo $KUBEVIRT_VERSION | ||
```{{execute}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot triple ticks somewhere. this does not render correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it also causes the remaining page to not render correctly
|
||
The command below applies a YAML definition of a virtual machine into our current Kubernetes environment, defining the VM name, the resources required (disk, CPU, memory), etc. You can take a look at the [vm.yaml](https://kubevirt.io/labs/manifests/vm.yaml) file if you have interest in knowing more about a virtual machine definition: | ||
The command below applies a YAML definition of a virtual machine into the current Kubernetes environment, defining the VM name, the resources required (disk, CPU, memory), etc. You can take a look at the [vm.yaml](https://kubevirt.io/labs/manifests/vm.yaml) file if you have interest in knowing more about a virtual machine definition: | ||
|
||
`kubectl apply -f https://kubevirt.io/labs/manifests/vm.yaml`{{execute}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the {{execute}} tags I keep seeing. They render on output. Its not just this file I see them on.
|
||
Next, we need to configure KubeVirt to use software emulation for virtualization. This is necessary for the Katacoda environment, but results in poor performance, so avoid this step in production environments. | ||
`kubectl get storageclass`{{execute}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, the {{execute}} renders on output
``` | ||
export VERSION=$(curl -Ls https://github.com/kubevirt/containerized-data-importer/releases/latest | grep -m 1 -o "v[0-9]\.[0-9]*\.[0-9]*") | ||
echo $VERSION | ||
```{{execute}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the {{execute}} may be messing with the three back tics. The remaining page does not render correctly.
|
||
Verify you now have a default storage class. You should see "kubevirt-hostpath-provisioner (default)" | ||
|
||
`kubectl get storageclass`{{execute}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, the {{execute}} renders and the remaidner of the page renders incorrectly.
|
||
`kubectl -n kubevirt get kubevirt kubevirt -o yaml`{{execute}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this {{execute}} and the remaining {{execute}} renders.
virtctl expose vmi testvm --name=testvm-ssh --port=22 --type=NodePort | ||
virtctl expose vmi testvm --name=testvm-http --port=8080 --type=NodePort | ||
`{{execute}} | ||
```{{execute}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this ex3ecute renders and the remainder of the page does not render correctly.
The {{execute}} tags are specific to the platform, and make the code in the
code block one-click executable in the terminal. They are not rendered
…On Wed, Jul 27, 2022 at 2:33 PM John Herr ***@***.***> wrote:
***@***.**** commented on this pull request.
check all occurences of {{execute}}. They all render on output and some
cause other parts of the page to render incorrectly
------------------------------
In kubevirt-101/step1.md
<#35 (comment)>
:
> (click on the text to automatically execute the commands on the console):
-`export KUBEVIRT_VERSION=v0.49.0`{{execute}}
+```
+export KUBEVIRT_VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt/releases/latest | jq -r .tag_name)
+echo $KUBEVIRT_VERSION
+```{{execute}}
I think you forgot triple ticks somewhere. this does not render correctly.
------------------------------
In kubevirt-101/step2.md
<#35 (comment)>
:
>
-The command below applies a YAML definition of a virtual machine into our current Kubernetes environment, defining the VM name, the resources required (disk, CPU, memory), etc. You can take a look at the [vm.yaml](https://kubevirt.io/labs/manifests/vm.yaml) file if you have interest in knowing more about a virtual machine definition:
+The command below applies a YAML definition of a virtual machine into the current Kubernetes environment, defining the VM name, the resources required (disk, CPU, memory), etc. You can take a look at the [vm.yaml](https://kubevirt.io/labs/manifests/vm.yaml) file if you have interest in knowing more about a virtual machine definition:
`kubectl apply -f https://kubevirt.io/labs/manifests/vm.yaml`{{execute}} <https://kubevirt.io/labs/manifests/vm.yaml%7B%7Bexecute%7D%7D>
what are the {{execute}} tags I keep seeing. They render on output. Its
not just this file I see them on.
------------------------------
In kubevirt-cdi/step1.md
<#35 (comment)>
:
>
-Next, we need to configure KubeVirt to use software emulation for virtualization. This is necessary for the Katacoda environment, but results in poor performance, so avoid this step in production environments.
+`kubectl get storageclass`{{execute}}
again, the {{execute}} renders on output
------------------------------
In kubevirt-cdi/step1.md
<#35 (comment)>
:
>
-It will take a while until all the pods are running. Retry the command until the output states that kubevirt is "Deployed".
+```
+export VERSION=$(curl -Ls https://github.com/kubevirt/containerized-data-importer/releases/latest | grep -m 1 -o "v[0-9]\.[0-9]*\.[0-9]*")
+echo $VERSION
+```{{execute}}
the {{execute}} may be messing with the three back tics. The remaining
page does not render correctly.
------------------------------
In kubevirt-cdi/step2.md
<#35 (comment)>
:
> -
-At a high level, a PersistentVolumeClaim (PVC) is created. A custom controller watches for importer specific claims, and when discovered, starts an import process to create a raw image named *disk.img* with the desired content into the associated PVC.
-
-We will first explore each component and later we will install them. In this exercise we create a hostpath provisioner and storage class. Also, we will deploy the CDI component using the Operator.
-
-#### Install Hostpath Provisioner
-
-Download the hostpath-provisioner deployment YAML and apply it.
-
-`wget https://raw.githubusercontent.com/kubevirt/hostpath-provisioner/main/deploy/kubevirt-hostpath-provisioner.yaml
-kubectl <https://raw.githubusercontent.com/kubevirt/hostpath-provisioner/main/deploy/kubevirt-hostpath-provisioner.yaml-kubectl> create -f kubevirt-hostpath-provisioner.yaml
-kubectl annotate storageclass kubevirt-hostpath-provisioner storageclass.kubernetes.io/is-default-class=true`{{execute}} <http://storageclass.kubernetes.io/is-default-class=true%7B%7Bexecute%7D%7D>
-
-Verify you now have a default storage class. You should see "kubevirt-hostpath-provisioner (default)"
-
-`kubectl get storageclass`{{execute}}
again, the {{execute}} renders and the remaidner of the page renders
incorrectly.
------------------------------
In kubevirt-migration/step1.md
<#35 (comment)>
:
>
-`kubectl -n kubevirt get kubevirt kubevirt -o yaml`{{execute}}
this {{execute}} and the remaining {{execute}} renders.
------------------------------
In kubevirt-migration/step2.md
<#35 (comment)>
:
> virtctl expose vmi testvm --name=testvm-ssh --port=22 --type=NodePort
virtctl expose vmi testvm --name=testvm-http --port=8080 --type=NodePort
-`{{execute}}
+```{{execute}}
this ex3ecute renders and the remainder of the page does not render
correctly.
------------------------------
In kubevirt-101/step1.md
<#35 (comment)>
:
> (click on the text to automatically execute the commands on the console):
-`export KUBEVIRT_VERSION=v0.49.0`{{execute}}
+```
+export KUBEVIRT_VERSION=$(curl -s https://api.github.com/repos/kubevirt/kubevirt/releases/latest | jq -r .tag_name)
+echo $KUBEVIRT_VERSION
+```{{execute}}
it also causes the remaining page to not render correctly
—
Reply to this email directly, view it on GitHub
<#35 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFKRM4VA4ZE5JSLSIZPECRDVWGFJDANCNFSM542EW3ZA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Chandler Wilkerson, RHCE, CKA
Sr. Software Engineer
Red Hat
|
since the tags render correctly on the platform. I would say this loogs good to me then. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cwilkers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updates: