Skip to content

Commit

Permalink
manifest: Change default values of env vars
Browse files Browse the repository at this point in the history
Use empty strings as default values for the env vars.
The Zone manager will set the defaults accordingly.
This allows to deploy the manifest as is.

Signed-off-by: Or Shoval <[email protected]>
  • Loading branch information
oshoval committed Dec 7, 2022
1 parent eb47eb5 commit fff1f4c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions manifests/secondarydns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ metadata:
---
apiVersion: v1
data:
DOMAIN: secondary.io
NAME_SERVER_IP: 127.0.0.1
DOMAIN: ""
NAME_SERVER_IP: ""
Corefile: |
.:53 {
auto {
Expand Down
2 changes: 1 addition & 1 deletion tests/vm_startup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const pollingInterval = 5 * time.Second
const testNamespacePrefix = "secondary-test"
const dnsPort = "31111"
const dnsIP = "127.0.0.1" // Forwarded to the node port - https://github.com/kubevirt/kubevirtci/pull/867
const domain = "vm.secondary.io"
const domain = "vm"

var testNamespace string

Expand Down

0 comments on commit fff1f4c

Please sign in to comment.