Support VirtualMachineClusterInstancetype and VirtualMachineClusterPreference #261
Conversation
Signed-off-by: Michael Henriksen <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
tests/vm_backup_test.go
Outdated
| _, err := f.KvClient.AppsV1().ControllerRevisions(f.Namespace.Name).Get(context.Background(), vm.Spec.Instancetype.RevisionName, metav1.GetOptions{}) | ||
| if err != nil && errors.ReasonForError(err) != metav1.StatusReasonNotFound { | ||
| return errors.ReasonForError(err) | ||
| DescribeTable("[test_id:10270]with instancetype and preference", Label("PartnerComp"), func(itFunc func() error, pFunc func() error, vmFunc func() error, delFunc func(), cleanupFunc func()) { |
There was a problem hiding this comment.
test id should be for the ns scoped entry, need to create another id for cluster one
Signed-off-by: Michael Henriksen <[email protected]>
mhenriks
force-pushed
the
clusterinstancetype
branch
from
9d0bbf4 to
66d0e65
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ShellyKa13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/lgtm |
|
/cherrypick release-v0.7 |
|
@ShellyKa13: new pull request created: #274 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Support
VirtualMachineClusterInstancetypeandVirtualMachineClusterpreferenceAlso better support namespaced versions by doing case insensitive check of
vm.spec.instancetype|preference.kindWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #258
Special notes for your reviewer:
Release note: