-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow switching VM power state during restore #306
Conversation
9bbd7d6
to
131ca82
Compare
Would it be better to have a single label that maps to the VM |
131ca82
to
27170f7
Compare
That's so much better, thanks for the suggestion. Will address it on Monday. |
27170f7
to
72cfb14
Compare
/test pull-kvp-functional-test |
25643c3
to
e8fa2b7
Compare
This commit implements a new label that allows switching the VM RunStrategy before restore. Signed-off-by: Alvaro Romero <[email protected]>
This commit adds func test coverage for the "velero.kubevirt.io/restore-power-on" and "velero.kubevirt.io/restore-power-off" labels. Signed-off-by: Alvaro Romero <[email protected]>
e8fa2b7
to
83e3b57
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-v0.7 |
@alromeros: #306 failed to apply on top of branch "release-v0.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Trying again after backporting previous PR |
@alromeros: #306 failed to apply on top of branch "release-v0.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This Pull Request enhances the behavior of VirtualMachine restores by introducing a new label:
This label can be added to the restore resource to explicitly control the power state of the VirtualMachine during the restore process. The VirtualMachine's state is backed up as it exists at the time of backup, but these labels allow you to override the default behavior and define the desired RunStrategy at restore time.
Which issue(s) this PR fixes:
Fixes # #294
Special notes for your reviewer:
There's some overlapping code with #304 but conflicts will be easy to solve.
Release note: