Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.7] Ignore VMIs from backup when owner VMs are excluded #314

Conversation

kubevirt-bot
Copy link

This is an automated cherry-pick of #273

/assign alromeros

Bugfix: Ignore VMIs from backup when owner VM is excluded

This commit updates the backup process for VMIs so, when the VMI is owned by a VM that's excluded from the backup, we also exclude the VMI without triggering an error.

Signed-off-by: Alvaro Romero <[email protected]>
This commit updates the functional tests to match the new behavior where we ignore the VMI backup if its owner is excluded from the backup.

Signed-off-by: Alvaro Romero <[email protected]>
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 2, 2025
@kubevirt-bot
Copy link
Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign awels for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alromeros
Copy link
Contributor

alromeros commented Jan 2, 2025

/close
There's a minor conflict, will address it in a custom PR

@kubevirt-bot
Copy link
Author

@alromeros: Closed this PR.

In response to this:

/close
There's a minor conflict in unit tests, will address it in a custom PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot
Copy link
Author

@kubevirt-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kvp-unit-test 0ca00cc link true /test pull-kvp-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants