-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add kubevirt_vmi_info module #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
label
Aug 14, 2024
kubevirt-bot
added
the
dco-signoff: yes
Indicates the PR's author has DCO signed all their commits.
label
Aug 14, 2024
0xFelix
added
major_changes
Major changes mean the user can CHOOSE to make a change when they update but do not have to
and removed
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
dco-signoff: yes
Indicates the PR's author has DCO signed all their commits.
labels
Aug 14, 2024
kubevirt-bot
added
the
dco-signoff: yes
Indicates the PR's author has DCO signed all their commits.
label
Aug 15, 2024
0xFelix
force-pushed
the
vmi-info
branch
4 times, most recently
from
August 15, 2024 12:09
e4fab35
to
923154b
Compare
0xFelix
added
minor_changes
New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
and removed
major_changes
Major changes mean the user can CHOOSE to make a change when they update but do not have to
labels
Aug 16, 2024
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lyarwood The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
labels
Aug 16, 2024
Extract the execute_module function from the kubevirt_vm_info module to make it available for other modules. Signed-off-by: Felix Matouschek <[email protected]>
Add the kubevirt_vmi_info module which allows to fetch information about VirtualMachineInstance(s). Signed-off-by: Felix Matouschek <[email protected]>
kubevirt-bot
removed
lgtm
Indicates that a PR is ready to be merged.
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
labels
Aug 19, 2024
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
dco-signoff: yes
Indicates the PR's author has DCO signed all their commits.
lgtm
Indicates that a PR is ready to be merged.
minor_changes
New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add the kubevirt_vmi_info module which allows to fetch information about
VirtualMachineInstance(s).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: