feat(kubevirt_vm_info): Set wait_condition based on running #91
Conversation
kubevirt-bot
added
release-note
0xFelix
added
minor_changes
0xFelix
force-pushed
the
wait-condition-info
branch
from
8729f10 to
d912631
Compare
kubevirt-bot
added
the
dco-signoff: yes
|
Nice improvement! Thanks! |
| @@ -194,6 +212,7 @@ def arg_spec(): | |||
| "namespace": {}, | |||
| "label_selectors": {"type": "list", "elements": "str", "default": []}, | |||
| "field_selectors": {"type": "list", "elements": "str", "default": []}, | |||
| "running": {"type": "bool", "default": True}, | |||
| "wait": {"type": "bool", "default": False}, | |||
| "wait_sleep": {"type": "int", "default": 5}, | |||
| "wait_timeout": {"type": "int", "default": 120}, | |||
There was a problem hiding this comment.
Let's add the following to arg spec definition to validate the param data passed to ensure the wait condition is provided when running is provided.
required_by=dict(
wait=('running', ),
),Signed-off-by: Felix Matouschek <[email protected]>
0xFelix
force-pushed
the
wait-condition-info
branch
from
d912631 to
74060f0
Compare
|
@maxamillion: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add the running parameter to kubevirt_vm_info from which the wait_condition is derived from when parameter wait is set to yes. Signed-off-by: Felix Matouschek <[email protected]>
0xFelix
force-pushed
the
wait-condition-info
branch
from
74060f0 to
71a8800
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
Add the running parameter to kubevirt_vm_info from which the wait_condition is derived from when parameter wait is set to yes.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: