Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prometheus port #1272

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix prometheus port #1272

merged 2 commits into from
Sep 17, 2024

Conversation

aerosouund
Copy link
Member

What this PR does / why we need it:

After observing multiple failures in sig performance lanes
e.g: https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12677/pull-kubevirt-e2e-k8s-1.29-sig-performance/1834501691534217216

The root cause has been tracked down to lack of existence of nodeport services and parsing ports using uint16 instead of uint

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

@aerosouund
fix: Add prometheus nodeports to manifests
32dc478 
Signed-off-by: aerosouund <[email protected]>
@aerosouund
fix: Use Uint for ports flags instead of Uint16
0696d2d 
Using uin16 results in explicit definition of the ports not being parsed correctly
leading ports to remain randomly assigned

Signed-off-by: aerosouund <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Sep 16, 2024
@aerosouund
Copy link
Member Author

cc: @dhiller @xpivarc @brianmcarey

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Sep 16, 2024 •
edited
Loading

@aerosouund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu 0696d2d link false /test check-up-kind-1.27-vgpu
check-up-kind-1.30-vgpu 0696d2d link false /test check-up-kind-1.30-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@akalenyu
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
dhiller
dhiller reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
@kubevirt-bot kubevirt-bot merged commit fc9be0a into kubevirt:main Sep 17, 2024
8 of 10 checks passed
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 17, 2024
@kubevirt-bot
Bump kubevirtci
68d58b8 
[fc9be0a Fix prometheus port](kubevirt/kubevirtci#1272)
[eff1926 Allow opting out of frequent etcd flushes to storage](kubevirt/kubevirtci#1266)
[939e610 fix the busybox netcat not found issue in fedora-test-tooling for s390x.](kubevirt/kubevirtci#1268)
[4ad94f0 Label rook storage class](kubevirt/kubevirtci#1267)
[88a4f6b fix: Wait until istio cni files appear before copying them](kubevirt/kubevirtci#1262)
[4cc1018 Run ./hack/bump-cdi.sh](kubevirt/kubevirtci#1249)
[6149a01 Include manifests that are part of gocli when checking for prepull images](kubevirt/kubevirtci#1265)
[1b17b20 fix: Remove extra slash in file path and remove unneeded sed](kubevirt/kubevirtci#1258)
[b35649a Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1257)
[374b5e9 bug: Move namespace and CRD files to names with higher alphabetical order to be created first](kubevirt/kubevirtci#1255)
[79bfd07 Run bazel run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-only-latest-three --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s --cluster-up-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-up/cluster](kubevirt/kubevirtci#1256)
[ba145b2 bug: Fix KSM flag passing to the gocli](kubevirt/kubevirtci#1254)
[8501d22 Opts package](kubevirt/kubevirtci#1217)
[4f37d07 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1250)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Sep 17, 2024
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 17, 2024
@kubevirt-bot
Bump kubevirtci
f8c6d98 
[fc9be0a Fix prometheus port](kubevirt/kubevirtci#1272)
[eff1926 Allow opting out of frequent etcd flushes to storage](kubevirt/kubevirtci#1266)
[939e610 fix the busybox netcat not found issue in fedora-test-tooling for s390x.](kubevirt/kubevirtci#1268)
[4ad94f0 Label rook storage class](kubevirt/kubevirtci#1267)
[88a4f6b fix: Wait until istio cni files appear before copying them](kubevirt/kubevirtci#1262)
[4cc1018 Run ./hack/bump-cdi.sh](kubevirt/kubevirtci#1249)
[6149a01 Include manifests that are part of gocli when checking for prepull images](kubevirt/kubevirtci#1265)
[1b17b20 fix: Remove extra slash in file path and remove unneeded sed](kubevirt/kubevirtci#1258)
[b35649a Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1257)
[374b5e9 bug: Move namespace and CRD files to names with higher alphabetical order to be created first](kubevirt/kubevirtci#1255)
[79bfd07 Run bazel run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-only-latest-three --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s --cluster-up-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-up/cluster](kubevirt/kubevirtci#1256)
[ba145b2 bug: Fix KSM flag passing to the gocli](kubevirt/kubevirtci#1254)
[8501d22 Opts package](kubevirt/kubevirtci#1217)
[4f37d07 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1250)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Sep 18, 2024
@kubevirt-bot
Bump kubevirtci
29c3acb 
[fc9be0a Fix prometheus port](kubevirt/kubevirtci#1272)
[eff1926 Allow opting out of frequent etcd flushes to storage](kubevirt/kubevirtci#1266)
[939e610 fix the busybox netcat not found issue in fedora-test-tooling for s390x.](kubevirt/kubevirtci#1268)
[4ad94f0 Label rook storage class](kubevirt/kubevirtci#1267)
[88a4f6b fix: Wait until istio cni files appear before copying them](kubevirt/kubevirtci#1262)
[4cc1018 Run ./hack/bump-cdi.sh](kubevirt/kubevirtci#1249)
[6149a01 Include manifests that are part of gocli when checking for prepull images](kubevirt/kubevirtci#1265)
[1b17b20 fix: Remove extra slash in file path and remove unneeded sed](kubevirt/kubevirtci#1258)
[b35649a Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1257)
[374b5e9 bug: Move namespace and CRD files to names with higher alphabetical order to be created first](kubevirt/kubevirtci#1255)
[79bfd07 Run bazel run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-only-latest-three --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s --cluster-up-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-up/cluster](kubevirt/kubevirtci#1256)
[ba145b2 bug: Fix KSM flag passing to the gocli](kubevirt/kubevirtci#1254)
[8501d22 Opts package](kubevirt/kubevirtci#1217)
[4f37d07 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1250)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
nirdothan pushed a commit to nirdothan/kubevirt that referenced this pull request Sep 25, 2024
@kubevirt-bot @nirdothan
Bump kubevirtci
ad15b45 
[fc9be0a Fix prometheus port](kubevirt/kubevirtci#1272)
[eff1926 Allow opting out of frequent etcd flushes to storage](kubevirt/kubevirtci#1266)
[939e610 fix the busybox netcat not found issue in fedora-test-tooling for s390x.](kubevirt/kubevirtci#1268)
[4ad94f0 Label rook storage class](kubevirt/kubevirtci#1267)
[88a4f6b fix: Wait until istio cni files appear before copying them](kubevirt/kubevirtci#1262)
[4cc1018 Run ./hack/bump-cdi.sh](kubevirt/kubevirtci#1249)
[6149a01 Include manifests that are part of gocli when checking for prepull images](kubevirt/kubevirtci#1265)
[1b17b20 fix: Remove extra slash in file path and remove unneeded sed](kubevirt/kubevirtci#1258)
[b35649a Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1257)
[374b5e9 bug: Move namespace and CRD files to names with higher alphabetical order to be created first](kubevirt/kubevirtci#1255)
[79bfd07 Run bazel run //robots/cmd/kubevirtci-bumper:kubevirtci-bumper -- -ensure-only-latest-three --k8s-provider-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-provision/k8s --cluster-up-dir /home/prow/go/src/github.com/kubevirt/project-infra/../kubevirtci/cluster-up/cluster](kubevirt/kubevirtci#1256)
[ba145b2 bug: Fix KSM flag passing to the gocli](kubevirt/kubevirtci#1254)
[8501d22 Opts package](kubevirt/kubevirtci#1217)
[4f37d07 Automatic bump of CentOS Stream to latest](kubevirt/kubevirtci#1250)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller dhiller left review comments

@brianmcarey brianmcarey Awaiting requested review from brianmcarey

Assignees

@akalenyu akalenyu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aerosouund @kubevirt-bot @akalenyu @dhiller