Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete k8s-1.24-ipv6 #929

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Delete k8s-1.24-ipv6 #929

merged 1 commit into from
Dec 13, 2022

Conversation

oshoval
Copy link
Contributor

@oshoval oshoval commented Dec 11, 2022

In favor of k8s-1.25-ipv6

Signed-off-by: Or Shoval [email protected]

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 11, 2022
@oshoval
Copy link
Contributor Author

oshoval commented Dec 11, 2022 •
edited
Loading

/cc @brianmcarey

To take after we check it on kubevirt (see bump PR running it there, need to authorize image please)
and merge kubevirt/project-infra#2514

@oshoval
Copy link
Contributor Author

oshoval commented Dec 12, 2022

/hold

depends on kubevirt/project-infra#2514

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2022
@oshoval oshoval marked this pull request as ready for review December 12, 2022 09:20
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2022
@kubevirt-bot kubevirt-bot requested a review from dhiller December 12, 2022 09:20
@oshoval
Copy link
Contributor Author

oshoval commented Dec 12, 2022

check-provision-k8s-1.24-ipv6 fails because the mentioned PR in the hold reason should be merged first

@oshoval
Copy link
Contributor Author

oshoval commented Dec 12, 2022

/hold cancel
PR was merged
amended to remove the old lane failure

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2022
@oshoval
Copy link
Contributor Author

oshoval commented Dec 12, 2022 •
edited
Loading

it seems it didn't fully catch the change yet
check-provision-k8s-1.24-ipv6 exists (seems as a zombie, without actual job)
but also check-provision-k8s-1.25-ipv6

will rerun soon commit amend

@oshoval
Delete k8s-1.24-ipv6
c40b3d6 
In favor of k8s-1.25-ipv6

Signed-off-by: Or Shoval <[email protected]>
@oshoval oshoval closed this Dec 12, 2022
@oshoval oshoval reopened this Dec 12, 2022
@oshoval
Copy link
Contributor Author

oshoval commented Dec 12, 2022

Maybe there is check-provision-k8s-1.24-ipv6 because it was already on this PR before the project-infra was delete
lets override it please, or clone this PR and see that it doesn't appear indeed

amend after a while didn't help so far

@brianmcarey
Copy link
Member

Maybe there is check-provision-k8s-1.24-ipv6 because it was already on this PR before the project-infra was delete lets override it please, or clone this PR and see that it doesn't appear indeed

amend after a while didn't help so far

I don't see it in the list of jobs now

@oshoval
Copy link
Contributor Author

oshoval commented Dec 12, 2022 •
edited
Loading

Maybe there is check-provision-k8s-1.24-ipv6 because it was already on this PR before the project-infra was delete lets override it please, or clone this PR and see that it doesn't appear indeed
amend after a while didn't help so far

I don't see it in the list of jobs now

Right gone (it was when i wrote it)

I just hope the rest would be triggered as they seem sleepy :)

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Dec 12, 2022 •
edited
Loading

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-provision-k8s-1.24-ipv6 e69bcce link true /test check-provision-k8s-1.24-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brianmcarey
Copy link
Member

/override check-up-kind-1.23-vgpu

@kubevirt-bot
Copy link
Contributor

@brianmcarey: Overrode contexts on behalf of brianmcarey: check-up-kind-1.23-vgpu

In response to this:

/override check-up-kind-1.23-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

brianmcarey
brianmcarey reviewed Dec 13, 2022
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
brianmcarey
brianmcarey approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@brianmcarey
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@kubevirt-bot kubevirt-bot merged commit 16f44a7 into kubevirt:main Dec 13, 2022
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Dec 15, 2022
@kubevirt-bot
Bump kubevirtci
b36e539 
[6b053d7 k8s, cluster-up: Copy istio CNI net conf to where Multus expects](kubevirt/kubevirtci#932)
[f930087 cluster-up: add environment variable to enable FIPS](kubevirt/kubevirtci#931)
[c1a7fde Upgrade cri-o to version 1.25 for 1.25/6 providers](kubevirt/kubevirtci#930)
[16f44a7 Delete k8s-1.24-ipv6](kubevirt/kubevirtci#929)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
@kubevirt-bot kubevirt-bot mentioned this pull request Dec 15, 2022
Merged
kubevirt-bot added a commit to kubevirt-bot/kubevirt that referenced this pull request Dec 16, 2022
@kubevirt-bot
Bump kubevirtci
077699b 
[5660e89 Enable PSA on any provider](kubevirt/kubevirtci#915)
[6304ac8 bump, cnao: k8s-1.2[4,5] to cnao v0.82.0](https://github.com/kubevirt/kubevirtci/pull/910)](https://github.com/kubevirt/kubevirtci/pull/933)
[6b053d7 k8s, cluster-up: Copy istio CNI net conf to where Multus expects](kubevirt/kubevirtci#932)
[f930087 cluster-up: add environment variable to enable FIPS](kubevirt/kubevirtci#931)
[c1a7fde Upgrade cri-o to version 1.25 for 1.25/6 providers](kubevirt/kubevirtci#930)
[16f44a7 Delete k8s-1.24-ipv6](kubevirt/kubevirtci#929)

```release-note
NONE
```

Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcarey brianmcarey brianmcarey approved these changes

@davidvossel davidvossel Awaiting requested review from davidvossel

@rmohr rmohr Awaiting requested review from rmohr

@dhiller dhiller Awaiting requested review from dhiller

Assignees

@brianmcarey brianmcarey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshoval @kubevirt-bot @brianmcarey