Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rootful kubevirt presubmit lanes #2646

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

brianmcarey
Copy link
Member

It was agreed on the mailing list[1] that the rootful lanes could be removed after the 0.59 release.

This will help reduce the CI load and hopefully lead to reduction in time to merge for approved PRs.

[1] https://groups.google.com/g/kubevirt-dev/c/LC8uSG2NMSA/m/YjkW1GVQHAAJ

/cc @xpivarc @dhiller @EdDev

It was agreed on the mailing list[1] that the rootful lanes could be
removed after the 0.59 release.

This will help reduce the CI load and hopefully lead to reduction in
time to merge for approved PRs.

[1] https://groups.google.com/g/kubevirt-dev/c/LC8uSG2NMSA/m/YjkW1GVQHAAJ

Signed-off-by: Brian Carey <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Mar 2, 2023
@brianmcarey
Copy link
Member Author

/hold

to allow for feedback on mailing list

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2023
@rmohr
Copy link
Member

rmohr commented Mar 2, 2023

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@xpivarc
Copy link
Member

xpivarc commented Mar 2, 2023

/lgtm

@dhiller
Copy link
Contributor

dhiller commented Mar 2, 2023

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@brianmcarey
Copy link
Member Author

/unhold

thanks everyone!

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2023
@kubevirt-bot kubevirt-bot merged commit a727aa4 into kubevirt:main Mar 3, 2023
@kubevirt-bot
Copy link
Contributor

@brianmcarey: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

In response to this:

It was agreed on the mailing list[1] that the rootful lanes could be removed after the 0.59 release.

This will help reduce the CI load and hopefully lead to reduction in time to merge for approved PRs.

[1] https://groups.google.com/g/kubevirt-dev/c/LC8uSG2NMSA/m/YjkW1GVQHAAJ

/cc @xpivarc @dhiller @EdDev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants