Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDI periodic: build and publish multi-arch images and manifest #3909

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhlhahaha
Copy link
Contributor

What this PR does / why we need it:
As the PR for build and publish multi-arch manifest has merged kubevirt/containerized-data-importer#3586
We can start to release multi-arch manifest

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 22, 2025
@zhlhahaha
Copy link
Contributor Author

@zhlhahaha
Copy link
Contributor Author

@brianmcarey can we rehearsal this job?

@zhlhahaha
Copy link
Contributor Author

This is emergency, as it block the build process. I have explain the reason here:
kubevirt/containerized-data-importer#3586 (comment)

@akalenyu
Copy link
Contributor

This is emergency, as it block the build process. I have explain the reason here: kubevirt/containerized-data-importer#3586 (comment)

I have two ways to unblock, let me know which one you prefer:

  • Merging this ASAP
  • Merging the revert and working on this

I am fine with either way you and @nunnatsa choose, meanwhile, I can give an lgtm here
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@zhlhahaha
Copy link
Contributor Author

Revert "Build and publish multi-arch images and manifest (#3586)" kubevirt/containerized-data-importer#3615

Hi @akalenyu ,
Can we rehearsal this job?

@akalenyu
Copy link
Contributor

Revert "Build and publish multi-arch images and manifest (#3586)" kubevirt/containerized-data-importer#3615

Hi @akalenyu , Can we rehearsal this job?

TBH I am not sure how to do that, maybe @brianmcarey can help

@zhlhahaha
Copy link
Contributor Author

TBH I am not sure how to do that, maybe @brianmcarey can help

Usually it can be trigger by input following tags, but I do not have the privileges. Also some jobs do not support rehearsal.
/rehearsal-periodic-containerized-data-importer-push-nightly

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2025
@kubevirt-bot kubevirt-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 26, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from akalenyu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants